Tao ad #130
Merged
Tao ad #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## computgraph #130 +/- ##
===============================================
+ Coverage 56.24% 59.73% +3.48%
===============================================
Files 55 55
Lines 3339 3340 +1
===============================================
+ Hits 1878 1995 +117
+ Misses 1461 1345 -116
☔ View full report in Codecov by Sentry. |
kunyuan
reviewed
Sep 17, 2023
| # Arguments: | ||
| - `g::Graph`: graph for which to find the total number of operations. | ||
| """ | ||
| function totaloperation(g::Graph) |
kunyuan
reviewed
Sep 17, 2023
src/computational_graph/eval.jl
Outdated
|
|
||
| # #@inline eval(d::DiagramId) = error("eval for $d has not yet implemented!") | ||
| # # | ||
| function evalGraph!(g::Graph) |
There was a problem hiding this comment.
passing an additional vector "leaf" which contains the leaf weight.
eval! should have the same behavior as the compiled function
kunyuan
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add front propagation Auto differentiation.
Add function that counts total number of "*" and "+" in a tree.