Configuration des classes CSS dans le template en même temps que dans le Form #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christophehenry
force-pushed
the
che/fix-dsfr_form_field
branch
2 times, most recently
from
9ec7e3c to
8b5abf0
Compare
christophehenry
changed the title
christophehenry
force-pushed
the
che/fix-dsfr_form_field
branch
from
8b5abf0 to
b798075
Compare
christophehenry
commented
Feb 5, 2024
christophehenry
force-pushed
the
che/fix-dsfr_form_field
branch
2 times, most recently
from
630d31d to
7f3f5bf
Compare
christophehenry
force-pushed
the
che/fix-dsfr_form_field
branch
from
7f3f5bf to
514b548
Compare
christophehenry
force-pushed
the
che/fix-dsfr_form_field
branch
from
514b548 to
b787657
Compare
|
Rebased. |
|
Merci ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Objectif
dsfr_form_fieldest inutile s'il n'est pas utilisé avecDsfrBaseFormpuisque la classe CSS est paramétrée dansDsfrBaseForm. C'est la seule chose qui est configurée au niveau du formulaire et pas au niveau template, ce qui est contre-intuitif.Cette PR ajoute cette logique dans un filtre à utilisé sur chaque
field.