Prévient les listes vides #208
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Il faudrait introduire un bloc avec un autre nom je pense, pour ne pas casser les utilisations actuelles. |
Si on crée un nouveau bloc on aura toujours une balise |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Objectif
Dans le header il peut y avoir des
<ul>vide s'il n'y a pas de contenue.🔍 Implémentation
Mettre la liste à l'intérieur du bloc
D'après ce que j'ai pu voir c'est au niveau du select du thème. Sur Wgtail si on choisit de ne pas afficher le select il reste une balise vide.
@Ash-Crow je n'ai pas en tête si ça peut avoir des incidences sur des projets qui utilisent Django DSFR.
🖼️ Images