-
-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Japanese translations #653
Conversation
✅ Deploy Preview for numpy-org ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@steppi Thank you for this preparation. Very useful. |
Thanks @AtsushiSakai for pointing out all of this text content which is missed by Crowdin. I don’t think it’s necessary to translate these things before we go live with the translations (hoping for next week) but it’s definitely worth considering for the near future. I’ll look into what we need to do to get Crowdin to pick these things up. For the newsletter sign up specifically, do you think translating that content could give the impression that the news letter is also available in translation? Though perhaps that’s something we also want to consider. |
@steppi Thank you for your comment.
Oh, great. I’m very happy to hear that.
I totally agree that. I believe current translation is already helpful for Japanese people.
Ah, you're right. If this statement was translated, one might mistakenly think that the newsletter is also translated. When translating, it would be best to specify that the newsletter is in English. I finished checking the whole rendering result, and found some untranslated sentence and some wrong translation. |
Great, thanks for catching these @AtsushiSakai.
Yes, that’s the plan. I’ll just cherry-pick the commits we need. I have another script for that.
Sounds good. Let’s do it. |
65a9d31
to
d279b14
Compare
d279b14
to
3f17d6e
Compare
@AtsushiSakai, the build failure was due to an inadvertently broken link. I've fixed it now. I'll merge after your approval. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I think there might be many small points to be improved, but I believe this is already useful resources for Japanese NumPy beginners.
@steppi Thank you for your kind support.
Thanks @AtsushiSakai! |
This PR contains only the Japanese translations from gh-639. I used a scripted interactive rebase to filter commits by message. The script is in the details section below.
@AtsushiSakai, please take a look to confirm everything is OK.
cc @rgommers @melissawm