drop perSystem from publisherArgs #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steveej
reviewed
Jan 21, 2025
phaer
force-pushed
the
fix-persystem
branch
4 times, most recently
from
c6fc34c to
27fd6fe
Compare
As this was broken from the start and is at least non-trivial to fix, if it possible at all. Happy about suggestions and/or PRs on how to re-introduce it in a known broken way.
|
I came to the believe that it's probably best to just drop it. At least for now. If anyone comes up with an ingenious way to support it properly I'd be more to happy to review a PR but I think the first priority should be to ship as little broken code in the main branch as possible. Users should still be able to refer to i.e. packages in the publisher flake via e.g. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @steveej