Merge pull request #90 from numtide/fix-sudo-for-text-file

proper sudo for text_file resource
numtide · Jan 11, 2025 · e3fb25e · e3fb25e
2 parents bd8a957 + cccf163
commit e3fb25e
Showing 1 changed file with 10 additions and 2 deletions.
diff --git a/resource/textfile/text_file_resource.go b/resource/textfile/text_file_resource.go
@@ -102,7 +102,7 @@ func resourceUpdateAndCreate(d *schema.ResourceData, m interface{}) error {
 	)
 
 	if d.Get("sudo").(bool) {
-		cmd = fmt.Sprintf("sudo %s", cmd)
+		cmd = fmt.Sprintf("sudo sh -c %s", shellescape.Quote(cmd))
 	}
 
 	stdout, stderr, err := sshsession.Run(d, cmd)
@@ -126,6 +126,10 @@ func resourceRead(d *schema.ResourceData, m interface{}) error {
 	{
 		cmd := fmt.Sprintf("stat -c '%%u %%g %%a' %s", shellescape.Quote(path))
 
+		if d.Get("sudo").(bool) {
+			cmd = fmt.Sprintf("sudo sh -c %s", shellescape.Quote(cmd))
+		}
+
 		stdout, _, err := sshsession.Run(d, cmd)
 		if err != nil {
 			d.SetId("")
@@ -181,9 +185,13 @@ func resourceDelete(d *schema.ResourceData, m interface{}) error {
 
 	cmd := fmt.Sprintf("rm -f %s", shellescape.Quote(path))
 
+	if d.Get("sudo").(bool) {
+		cmd = fmt.Sprintf("sudo sh -c %s", shellescape.Quote(cmd))
+	}
+
 	stdout, stderr, err := sshsession.Run(d, cmd)
 	if err != nil {
-		return errors.Wrapf(err, "error while deletin file %s:\nSTDOUT:\n%s\nSTDERR:\n%s\n", path, string(stdout), string(stderr))
+		return errors.Wrapf(err, "error while deleting file %s:\nSTDOUT:\n%s\nSTDERR:\n%s\n", path, string(stdout), string(stderr))
 	}
 
 	return nil