Fix error in use of --extensionDirectory #1625
Conversation
CharliePoole
requested review from
manfred-brands and
veleek
and removed request for
manfred-brands
|
@veleek Essentially, this is a sort of spike to find out what works for the user. I already merged it to make it available. Two more stages will follow: (1) changes to our CI recipe to allow automated testing of this sort of change and (2) adding those tests and refining the fix based on feedback. For that reason, even though this PR is already merged, I'd like you to review it, which GitHub seems to allow. I'll also ask you to review the subsequent PRs in this series as they come along. If you're not able to do this one, as usual, just let me know and I'll re-assign it. |
|
I will try to get this reviewed today or tomorrow. |
|
Cool. Also, chime in on the issue about how this should really work after you've looked at it. I'm leaning toward option 2 myself. |
| @@ -71,7 +71,7 @@ public ConsoleRunner(ITestEngine engine, ConsoleOptions options, ExtendedTextWri | |||
| foreach (string extensionDirectory in extensionPath.Split(new[] { Path.PathSeparator }, StringSplitOptions.RemoveEmptyEntries)) | |||
| _extensionService.FindExtensionAssemblies(extensionDirectory); | |||
|
|
|||
| foreach (string extensionDirectory in _options.ExtensionDirectories) | |||
| foreach (string extensionDirectory in _options.ExtensionDirectories) | |||
There was a problem hiding this comment.
Both changes in this file look like unintentiontal whitespace additions.
| if (_extensionService != null) | ||
| { | ||
| foreach (IDriverFactory factory in _extensionService.GetExtensions<IDriverFactory>()) | ||
| _factories.Add(factory); |
There was a problem hiding this comment.
This could be switched to use _factories.AddRange(...) instead of manually iterating.
Fixes #1613