feat: Add .NET9 agent #1642
Merged
feat: Add .NET9 agent #1642
+35
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Super! Thanks for getting this done. It's the last big piece needed for 3.20. |
CharliePoole
requested changes
Mar 12, 2025
There was a problem hiding this comment.
Looks pretty good to me. I think your decision to keep all the dependent assemblies as is makes sense. We can upgrade any that need it later on.
Can you upgrade the agent unit tests by adding a .NET 9.0 build? We could also use some package tests that target 9.0. Both can be pretty minimal.
OTOH if you are out of time, this is good to merge, and one of us will add the tests later.
Thanks again!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1602