Fixing Issue Cacti#129

PCOMMAND Device[XXXX] WARNING: Recache Event Detected for Device
nuno-silva · Mar 29, 2020 · 158e5d0 · 158e5d0
1 parent 27c7749
commit 158e5d0
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/CHANGELOG b/CHANGELOG
@@ -2,6 +2,7 @@ The Cacti Group | spine
 
 1.2.11
 -issue#122: Can't compile spine on Openbsd
+-issue#129: PCOMMAND Device[XXXX] WARNING: Recache Event Detected for Device
 -issue#134: Feature request: Loop Waiting on 2 of 2 pollers when database name is incorrect
 -issue#144: Improve MySQL Retry Logic
 -issue#149: Segmentation fault in spine 1.2.10 due to IPv6 address using IPv4 ICMP ping

diff --git a/poller.c b/poller.c
@@ -745,9 +745,11 @@ void poll_host(int host_id, int host_thread, int last_host_thread, int host_data
 									}
 									poll_result[0] = '\0';
 									snprintf(poll_result, BUFSIZE, "%s", sysUptime);
-								} else {
+								} else if (strstr(reindex->arg1, ".1.3.6.1.2.1.1.3.0")) {
 									poll_result = snmp_get(host, reindex->arg1);
 									snprintf(sysUptime, BUFSIZE, "%s", poll_result);
+								} else {
+									poll_result = snmp_get(host, reindex->arg1);
 								}
 
 								if (is_debug_device(host->id)) {

diff --git a/snmp.c b/snmp.c
@@ -383,7 +383,7 @@ char *snmp_get(host_t *current_host, char *snmp_oid) {
 
 					snprint_value(temp_result, RESULTS_BUFFER, vars->name, vars->name_length, vars);
 
-					snprint_asciistring(result_string, RESULTS_BUFFER, temp_result, strlen(temp_result));
+					snprintf(result_string, RESULTS_BUFFER, "%s", trim(temp_result));
 				} else {
 					SPINE_LOG_HIGH(("ERROR: Failed to get oid '%s' for Device[%d]",  snmp_oid, current_host->id));
 				}