Improve Map UX, move help text to Bootstrap's Offcanvas component #1981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nurikk
reviewed
Apr 22, 2024
| @@ -32,7 +32,7 @@ export class MapComponent extends Component<PropsFromStore & MapApi & WithTransl | |||
| width: 0, | |||
| height: 0, | |||
| visibleLinks: defaultVisibleRelationsLinks, | |||
| legendIsVisible: true, | |||
| legendIsVisible: false, | |||
There was a problem hiding this comment.
I like this idea, can you please persist this flag into local storage? example code here
|
Has this been tested when frontend is opened inside HA? How does this behaves when the offcanvas is nested inside HA's UI? |
Closed
It hasn't. Though very good point. Or perhaps would you mind testing it? |
|
hey @S33G I'm working on a new map implementation, can you please have a look at map2.0 branch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I feel this information is useful, but once you know it you don't need to keep reading it.
I moved it to a Offcanvas component and added a fixed position button to open the Offcanvas sidebar.
Before:
After:
