Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[T5A1][F11-B3]Praveer Tewari #1697

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions doc/DeveloperGuide.md
Original file line number Diff line number Diff line change
Expand Up @@ -51,3 +51,31 @@
* Problem: Test fails during the very first time.<br>
Solution: The output of the very first test run could be slightly different because the program
creates a new storage file. Tests should pass from the 2nd run onwards.

### User stories

1. As a user, I can search contacts by their tags, so that I can find every contact of a certain tag.
2. As a user, I can create groups, so that I can split my contacts into different groups.
3. As a user, I can view all contacts of a certain group.

### Use Cases

Use case: 01 - Rename Tag
Actor: User
1. User chooses tag to rename.
2. AddressBook requests for new tag name.
3. User enters new tag name.
4. AddressBook renames the tag.
Use case ends.
Extensions:
1a. AddressBook detects no such tag name.
1a1. AddressBook informs user no such tag name exists.
Use case ends.

### Non-Functional Requirements

1. Performance - The system should respond to every command within a second.
2. Quality - The system should be easily understood and be usable by someone who has never used a CLI program before.



6 changes: 5 additions & 1 deletion src/seedu/addressbook/commands/CommandResult.java
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
public class CommandResult {

/** The feedback message to be shown to the user. Contains a description of the execution result */
public final String feedbackToUser;
private final String feedbackToUser;

/** The list of persons that was produced by the command */
private final List<? extends ReadOnlyPerson> relevantPersons;
Expand All @@ -32,5 +32,9 @@ public CommandResult(String feedbackToUser, List<? extends ReadOnlyPerson> relev
public Optional<List<? extends ReadOnlyPerson>> getRelevantPersons() {
return Optional.ofNullable(relevantPersons);
}

public String getFeedbackToUser() {
return feedbackToUser;
}

}
5 changes: 5 additions & 0 deletions src/seedu/addressbook/data/person/Printable.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
package seedu.addressbook.data.person;

public interface Printable {

}
2 changes: 1 addition & 1 deletion src/seedu/addressbook/ui/TextUi.java
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ public void showResultToUser(CommandResult result) {
if(resultPersons.isPresent()) {
showPersonListView(resultPersons.get());
}
showToUser(result.feedbackToUser, DIVIDER);
showToUser(result.getFeedbackToUser(), DIVIDER);
}

/**
Expand Down