[T7][W11-C2] #117
Open
[T7][W11-C2] #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. Remove format check for phone, email and address in add command. (Passed JUnit test)
* First revision to AboutUs.md * Update to add TA info * update team roles and add Rachael's photo * Update AboutUs.md * Update image * Update image
* Add saving data, faq and command summary section in user guide * Add 'table of contents' and 'quick start' * Update some minor formatting in quick start section * Change 'contact' to 'task' * Add faq link in content list * Removed clear command. Chang all instances of addressbook/this app/the app to Agendum.
* Update README.md, AboutUs.md and UserGuide.md * Update Product Survery and Glossary in Developer Guide * Update Product Survey and Non-Functional Requirements in Developer Guide * Update Use Cases in Developer Guide * Clean up Use cases section of Developer Guide - Change Agendum to System, User to Actor * Update User Stories in Developer Guide * Organise formattings in Developer Guide * Fix spelling errors in Developer Guide * Update some minor formatting in Developer Guide * Fix new line issues with command format description
zzzzwen
referenced
this pull request
in CS2103AUG2016-W13-C3/main
Oct 10, 2016
…er methods to the Task class
…e and schedule task method in model
* Rename ChangeSaveLocationRequest to SaveLocationChange * Update test * Put literals in variable for Events * Rewrite Store Command test one method per test case * Rewrite test for load command. One method per test case * Rewrite Storage tests to follow convention * Rewrite logic manager test for store and load * Extract variables out of setup * Rename SaveLocationChange to ChangeSaveLocation
* solution? * rename messages * update unique task list to throw duplicate task exception * update to do list for exceptions * handle duplicate task exceptions in mark/unmark commands, rename methods in model/managers, rename logging messages * sort based on last updated time * remove nanoseconds * minor change to comments
* Draft for alias/unalias command * remove logic manager and general command dependency on commandlibrary * Convert alias key and value to lower case in parser * Check if alias key is a reserved command word * fix help window imports * move command library * Add storage for alias command library * remove unused method in logic * Update method names in storage * renaming methods * update comments in commandlibrary class * all commandLIbrary from logic manager * remove singleton * Add alias/unalias logic manager test * fix error in storage manager test * add alias storage manager test * fix failing config test * Use Reflection+Lambda to get Commands * Ignore command.json * alias key should be case insenstive, update test * Update .gitignore Remove commands.json * Do not allow symbols for alias, add stub for for add invalid args * Add taggings * add final * Remove unused local variables * update messages * Update method name and comments * Renamed classes and methods from commandlibrarystorage to aliastablestorage * Make command library a singleton * remove unused variable
* Update commandboxhistory * Update test claiming * Update some comments * Update some format issue and call singleton get instance * change previous to latest
* Update help window style * Update command format * Update helpwindow to integrate into mainwindow * Create event to close help window
* Add jump to list request event * Make highlighting disappear after several seconds * A bit clean up * Highlight existing task when adding duplicates * Remove sop * Update ui diagrams * Enable selection only when needed * Update color to be more obvious * Support highlighting for rename/schedule task * Update highlight color * Disable click on the list * Change shortcut key of helpwindow to be ctrl+H * Update task card date time format * add shortchut key as ctrl-z for undo * Fix the mainwindow request focusing automatically issue * Update task card handle for gui tests * Extend gui test time * Extend some gui test time * Add icons for different panels * Some ui updates * Updates for gui tests * Some font size changes * Remove split divider * Remove unnecessary imports * Format time * Update time format in gui task card handle * Update messages to remove any index * Update gui test * Update task panel name
* Abstract some code in Parser * Add comments
* Fix: Avoid reassigning parameters such as 'endDateTime' * Fix: Avoid reassigning parameters such as 'endTime' * Fix: Avoid reassigning parameters such as 'args' * Fix: Use explicit scoping instead of the default package private level * Fix: Use explicit scoping instead of the default package private level
* Change testapp config file path * Add method which creates temp config file in sandbox * Update TestApp and StorageManagerTest to use temp config file * Add new private variable to store config file path * Update MainApp, StorageManager and TestUtil to use the new variable
* Fix the shortcut key conflicts * Inline the find command message * Remove seconds in the status bar time label * Change overdue and upcoming task background color * Update highlighting colors * Fix some bugs related to pop up window showing time * Set max height of result pop up window to be screen height * Update helpwindow gui test * Update gui test for the find message * Some code claim * Add id to time label * Remove unused code
* Add xml adapted task test * add gui settings test * Add collection util test * Add null test for Version * Add author tag * Add empty and null tests for DateTimeUtils * Add more tests to Unmodifiable observable list * rename some methods * Add unit tests for task * unique task list unit test draft * Add name test * Rewrite unmodifiable observavle list equals test * Rewrite GuiSettings test * Refactor Name test * remove comment * Add equals and hascode test to config test * rename name test methods * add set alias file path test to config * Remove reassigning of parameters in Name * Remove null comparison in config test * remove runtime exceptions in test util * Remove unused imports * Remove unnecessary constructor * Add todolist test * Add author tag * Update task test * add alias test back * rename method from command library to alias table * add unique task list test * Update logic manager test, add missing @test, check for duplicate task in mark and unmark * modify schedule in logic manager test * Update task card handle * update compare time in test task * update task builder for task with time * update add command test * update renamed test * Increase config tests to cover everything * Remove unreachable code in ToDoList * Remove in-line static references in todolist * Rewrite FileUtilTest * Organise imports * Update test method name * Add missing test tag and exit command test * Update exit test * Update file util test - Remove unused imports - make invalid directory more invalid * Convert object to string * Change testapp config file path * Add method which creates temp config file in sandbox * Update TestApp and StorageManagerTest to use temp config file * Rename all methods with name "setup" to "setUp" * remove unsused imports in TaskTest,TestTask,DateTimeUtilsTest * Change ConfigUtilTest static accessors * Change some variables in GuiSettingsTest to private * Update variable access modifiers * Use constants in test task, remove redundant import * Remove null comparison in gui settings test * attempt to add test for add command * make by, from and to case insensitive * Change null comparison in version test * Remove non-final static variables in TypicalTestTasks - and changed all affected classes * Add new private variable to store config file path * Update MainApp, StorageManager and TestUtil to use the new variable * Add MainAppTest - tests initConfig - tests initUserPrefs * Add more tests * Remove unused imports * Replace System.exit with Assert.fail * Add getAliasTable for testing usage * Add tests for initAliasTable * Modify XmlAdaptedTask to be able to support tasks with no updated time specified * Update GuiSettingsTest tests * Add UserPrefs test for equals and hashcode * Add UserPrefs Test * Move UserPrefsTest to model package * Update add/schedule date time parser * revert changes in parser.java * sort tasks only when comparing panels * resolve merge conflicts
* Remove redundant import and add header comments for methods in the Task class * Update read only task * Rename method in ModelManager * remove "this is" in model manager comments * update undo and previous lists related data/functions in model * Add _ to denote private variables in Task * Update alias table changed event * Remove redundant report and update comments in alias table storage files * Indentation formatting for todolist and readonlytask * indentation formatting for parser class * update parser comments * update commands and code claim * add white space * add spaces * update comments for command library and results * adjust indentation * update tests * fix failing tests * add author tag for gui test
* Maven Google Calendar SDK * SyncManager * Create new classes * Sync command * Add more gradle dependencies * Create Sync & SyncProvider interfaces * ModelManager supports Sync * Sync methods in Model * Add Sync to parser * SyncManager * Sync provider Google * Google stuff * Revert bad merge change * Basic event adding hooks workings * tag code * CRUD support * Cleanup * Sync on/off is now persisted using credential file * Multithreading and concurrency * Multithreading and concurrency support in SyncProvider made it trival to support adding add tasks when Sync is turned on * Small cleanup * Add mockito dependency * SyncManagerTests * Testing sync on/off * Remove sync on * tag syncmanagertest * Simple testing in GoogleTests * Add invalid sync * deleteCalendadrMethod * Much more Google calendar testing * test sync on too * tag code * Add comments
* Delete checkstyle.xml * Delete checkstyle-noframes-sorted.xsl * Delete excludeFilter.xml * Delete Collate-GUI.jar * Delete Collate-TUI.jar * Delete copyright.txt * Delete gradle.properties
* Set taskspanel class to be abstract * Update some tests name and comments * Add gui test for mark command * Add gui test for unmark command * Update commandbox test
* Tagging changes * More comments * minor var use * Fix tests
* Test abstract Command class * IncorrectCommandTests * Remove boiler comments * nuused imports
* extract method in model manager * update comments rename toDoList * update messages (remove - in angle bracket, new message for alias), remove some code from undo in logic manager test
* A fix for the add parser * cleanup * Update to check for quotaiton * Parse tests * Update schedule format * Change escape character to single quotation only, only allow by/from and to format, update logic manager test to test escape character
* Remove old sample data folder * Add ManulTesting folder and SampleData.xml to src/test/data * Update data im sample * Add data to sample, up to 50 * Add testscript * Add sync command * Update sync command description * Update test script
* update add command format message * update messages - add message for missing task, replace all duplicate task message with the same constant
* Some code refactoring * Update some access level * Update some static fields * Update some comments
* Tests improvements * Verification fixes * Turn on tests again * Gradle clears stored credentials when starting tests * forceful verbose RM * Clean up credentials after sync on tests * Run tests in order * @BeforeClass that actually works * Use synccode * Updat tests
* Update sentence structures and wording - Make it more informal like 2101, directly address the user * Update spacing * Tag user and developer guide, update about us and collate * Update UserGuide.md * Update major contributions * Update matric no. * Update matric no * Add collate.bat * Re-collate files * Update dev guide tags * Re-collate * add missing bracket * Update User stories * Update NFR * Add images for user guide * Update quick start guide * Update features * Update UserGuide.md * Change path to file for store and load * Update store and load use cases * Update user stories to match user guide * Update alias and unalias - Alias supports multiple aliases - Unalias only support removing the alias command * Add unalias and unmark. Update alias * Re-collate * Add profile pictures * Update profile pictures * Update README.md * Update profile pictures * Update introduction and getting started of User Guide * Format introduction and getting started of user guide * update general things to note for command section * update add command and date time format * formatting introduction and getting started * Update formatting again * renaming a task * scheduling a task * update formatting * more formatting * update mark/unmark and delete * update find and list * further updates * replace mark multiple * more formatting fixed * Add patterns and principles * add main insights from product survey * update developer guide model component * more changes (especially to command table and store/load description) * update formatting * fix keyboard shortcut * Update keyboard shortcuts * Update alias and unalias * Fix spelling and formatting * Update user guide language and formatting * Update user guide and remove - in angle brackets * update deadline/event time rule * update command summary for user guide * Update ui screenshot * Updated some diagrams * update user guide to match pictures * update deleted result description * add missing br * fix noticeable formatting * remove support for hourminute * modify developer guide * Add some screenshots and update format a bit * Remove unnecessary new lines * Update icon * update some formats issue * Update 'code written' section * Update formatting of 'code written' section * Update AboutUs.md * update date time description for user guide * Update some screenshots * Add sync command, remove non-image command summary * Update Storage description * Update command summary picture * update high level design of developer guide * Update Storage Object Diagram * explain model and undo * Fix error in Storage Object Diagram * update activity diagram, add br, update description of undo * make mark indices clearer * update dev guide diagrams * attempt to fix table * update description * update activity diagram * update description for add with single quotation marks * update command summary of user guide * update command summary. replace ` with '. * Update user stories * Update user stories * Update find diagrams * Update user stories - Remove 'unlikely' since "1 star" already means unlikely * Update use cases - change 'path-to-file' to 'location' * update use cases * Remove everything collate * update about us * Update test script * update diagrams ppt and storage diagram * Update acknowledgements * Update ack * Update acknowledgements * Update Acknowledgements (final) * add google sync disclaimer * Bring back UsingGradle.md from upstream project * Fix Google Calendar anchor tag * Fix wording in Google Calendar section for accuracy * minor grammar * Add more dependencies * Add a paragarph about Sync * Tiny about-us update * Minor update to sync section * Delete some unusable comments * update model diagram
* Final collate pushes * Fix author * Update collate for A0133367E
* Fix test scripts * missing #userguide * Update AboutUs.md * Update AboutUs.md * Bring back the brackets * index -> id, add disclaimer to note task name as id changes * update about us
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.