Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[T7][T10-C1] #69

Open
wants to merge 810 commits into
base: master
Choose a base branch
from

Conversation

RonaldLWM
Copy link

No description provided.


>Format: **Add** <index> #tag1 #tag2

Example: Add E1 #win #victor #finally

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't I add the tag when I am adding the task? If No, then take note that your add tag process continues for two commands..which is not too good right? Why can't you make it an optional parameter in the add command

Copy link

@jingrui-who jingrui-who Oct 14, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok noted. we have already done that but not stated specifically in the user guide under add.
this function is for user to add additional tags


>Format : **Add** [<event description>; <date(DDMMYY)>; <start time>; <end time>]

Example: Add [Sam's birthday party; 20/12/16 ; 9pm]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why should Jim use a square bracket for events and not for other task types?
Consistency is good to get users on board.

Copy link

@jingrui-who jingrui-who Oct 14, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we wanted to add a square bracket to differentiate between deadline and event/event and todo since those two may overlap. ie. event can only have a start time but not an end time or the other way around which the program might mistaken it for a deadline.


>Format: **Add** <deadline description>; <date(DDMMYY)>; <end time>

Example: Add complete report; 120916; 1900

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So you are supporting multiple date/time formats? (above its different.) Please mention this explicitly.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok. we will make the changes. our task manager can only add according to this format currently.


####2.1 Edit all task details in one go

>Format: **Edit** <index> [<event description>; <date>; <start time>; <end time>; <tags>; !]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whats the exclamation mark? How do I add it in first place?

Copy link

@jingrui-who jingrui-who Oct 14, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is for marking priorities so it should be added after the tags


>Note: Removing start time from events will automatically convert them into deadlines.

>Note: Removing end time from deadlines will automatically set the end time of the deadline to 2359.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good description!

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that is a good comment. Appreciated!


>Format: **Edit** <index> **end** <end time>

Example: Edit E1 end 1900

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If any of the keywords like end show up in the description make sure to handle it.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok noted.


> Format: Done <index>-<index>

> Format: Done <index>, <index>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good. Make sure to handle cases like T1-E3


>Format: **Delete** <index> #tag1 #tag2

Example: Delete E1 #win #victor #finally

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is this different from editing a tag? Looks a bit inconsistent to add this to delete.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you mean that
Edit D1 #doOrdie > #101

can be changed to
Edit E1 #win #victor #finally
which will delete the tags?

in a sense it will make the edit function more flexible but it may confuse the user since they will take edit as pure editing and will it not be defying the SRP?

@nirandiw
Copy link

Hi guys,

The user guide looks much better now apart from few inconsistencies here and there. Take note of the things I have mentioned here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants