[T2A2] [T01-T3] Teo Shu Qi #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -210,6 +199,9 @@ public static void main(String[] args) { | |||
| showWelcomeMessage(); | |||
| processProgramArgs(args); | |||
| loadDataFromStorage(); | |||
| for ( int i =0; i<20; i++ ) { | |||
| System.out.println(i); | |||
| } | |||
| * The number of data elements for a single person. | ||
| */ | ||
| private static final int PERSON_DATA_COUNT = 3; | ||
|
|
There was a problem hiding this comment.
Why do you remove all these? Hmm..
| else { | ||
| return ""; | ||
| } | ||
| } |
There was a problem hiding this comment.
You should remove this method, since you have removePrefix method.
| @@ -1150,9 +1168,23 @@ private static String getUsageInfoForExitCommand() { | |||
| * @param sign Parameter sign to be removed | |||
| * @return string without the sign | |||
There was a problem hiding this comment.
Forget to change the header comment
|
@teoshuqi Some comments added. Please close the PR after reading comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ready For Review