[T4A1][T01-T1]Cherry Goh #111
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -56,4 +56,9 @@ public int hashCode() { | |||
| public boolean isPrivate() { | |||
| return isPrivate; | |||
| } | |||
|
|
|||
| public String getPrintableString() { | |||
| // TODO Auto-generated method stub | |||
There was a problem hiding this comment.
Remove default comments to ensure that the code is clean and easy to read.
|
|
||
| public String getPrintableString() { | ||
| // TODO Auto-generated method stub | ||
| return value; |
There was a problem hiding this comment.
Indentation problem here? Our coding standard requires you to use 4 spaces instead of tabs. You can configure Eclipse to convert tabs to spaces automatically.
| @@ -0,0 +1,7 @@ | |||
| package seedu.addressbook.data.person; | |||
|
|
|||
| public interface Printable { | |||
There was a problem hiding this comment.
Missing header comment. All non-trivial classes and methods should have javadoc format header comments.
|
@cherrygoh Some comments added. Please close the PR after reading them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ready for review.