Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[T4A2][T01-T04] Aung Swumm #116

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

ashpa
Copy link

@ashpa ashpa commented Jul 3, 2017

No description provided.

public class Tagging {
private static final String ADD_COMMAND = "add";
private static final String DEL_COMMAND = "delete";
private ArrayList<String> allTagHistory;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the class diagram given in the exercise, the list of Tagging objects should not be in this class. If it was in this class, the diagram would be like this:
image

private static final String DEL_COMMAND = "delete";
private ArrayList<String> allTagHistory;

public void recordTagHistory(String command, String name, String tag) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No header comment.


import java.util.ArrayList;
/*
* Association class that records all addition and deletion of tags during a session

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A more precise description is Represents an adding or removing a Tag to/from a Person.

@jeffryhartanto
Copy link

@ashpa
Some comments added. Please close the PR after reading comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants