[W7.7][T10-B1] AcquaiNote #70

Hailinx · 2017-10-05T01:58:33Z

No description provided.

jeffryhartanto · 2017-10-07T04:23:02Z

docs/DeveloperGuide.adoc

@@ -729,8 +729,26 @@ Priorities: High (must have) - `* * \*`, Medium (nice to have) - `* \*`, Low (un

 |`* * *` |user |find a person by name |locate details of persons without having to go through the entire list

+|`* * *` |user |add details to a certain contact after adding them |have more information available afterwards


Isn't it more like edit?

jeffryhartanto · 2017-10-07T04:24:24Z

docs/DeveloperGuide.adoc

@@ -729,8 +729,26 @@ Priorities: High (must have) - `* * \*`, Medium (nice to have) - `* \*`, Low (un

 |`* * *` |user |find a person by name |locate details of persons without having to go through the entire list

+|`* * *` |user |add details to a certain contact after adding them |have more information available afterwards
+
+|`* * *` |user |be notified if I were to delete a contact |I don’t mistakenly delete a contact


This is more like a detail that should be recorded in the use case of delete contact's user story.

jeffryhartanto · 2017-10-07T04:26:01Z

docs/DeveloperGuide.adoc

 |`* *` |user |hide link:#private-contact-detail[private contact details] by default |minimize chance of someone else seeing them by accident

+|`* *` |user |use link:#right-click-menu[right click menu] for most link:#common-commands[common commands] |no typing is required and makes my life easy


Remember that the project defines that the user is a typist.

jeffryhartanto · 2017-10-07T04:26:28Z

docs/DeveloperGuide.adoc

+
+|`* * *` |user |show list of favourite contacts |quickly find people I contact often
+
+|`* * *` |user |be notified when entering user with same name |avoid confusion in the future


More like a use case.

jeffryhartanto · 2017-10-07T04:27:28Z

docs/DeveloperGuide.adoc

+
+|`* * *` |user |have a more flexible addition of contact |add contacts without address or email as compulsory elements
+
+|`* * *` |user |show list of favourite contacts |quickly find people I contact often


Don't forget to add a user story to add contacts into favourite contacts.

jeffryhartanto · 2017-10-07T04:36:10Z

docs/DeveloperGuide.adoc

+*MSS*
+
+1.  User requests to add a person
+2.  User inputs desired details, eg: address, email, birthday, etc...


Step 1 and 2 can be combined into User requests to add a person with some missing attributes

jeffryhartanto · 2017-10-07T04:37:36Z

docs/DeveloperGuide.adoc

+** 3a1. AddressBook displays message “Wrong password”.
+
+Use case resumes at step 2.
+


Overall, it's good that you write use cases for each user stories, but some of them shouldn't be a user stories and also some use cases are wrong. Please check them again and update it accordingly.

jeffryhartanto · 2017-10-07T04:38:06Z

docs/DeveloperGuide.adoc

+.  Should be able to sort within 1 second.
+.  A user with average software using skills should be able to understand the user interface within 20 minutes.
+.  A new user who is able to comprehend simple english can use the application within 20 minutes.
+.  Should only store data locally unless user shares with other applications.


Good, all NFRs are specific.

jeffryhartanto · 2017-10-07T04:38:33Z

src/main/java/seedu/address/storage/AddressBookStorage.java

@@ -41,4 +41,5 @@
     */
    void saveAddressBook(ReadOnlyAddressBook addressBook, String filePath) throws IOException;

+    void backupAddressBook(ReadOnlyAddressBook addressBook) throws IOException;


Put header comment here.

jeffryhartanto · 2017-10-07T04:39:15Z

src/main/java/seedu/address/storage/XmlAddressBookStorage.java

@@ -74,4 +75,8 @@ public void saveAddressBook(ReadOnlyAddressBook addressBook, String filePath) th
        XmlFileStorage.saveDataToFile(file, new XmlSerializableAddressBook(addressBook));
    }

+    public void backupAddressBook(ReadOnlyAddressBook addressBook) throws IOException {
+        saveAddressBook(addressBook, filePath.concat("backup.fxml"));


backup.fxml can be set into a constant.

jeffryhartanto · 2017-10-07T04:40:53Z

@Hailinx @qihao27 @valensia0711 @aaronyhsoh
Some comments added. Good job for completing V1.0, keep up the good work.

jeffryhartanto · 2017-10-14T12:03:31Z

docs/AboutUs.adoc


 Role: Developer +
-Responsibilities: UI
+Responsibilities: Logic
+


Good job for updating AboutUS.

jeffryhartanto · 2017-10-14T12:04:15Z

docs/DeveloperGuide.adoc

-+
-Use case ends.
-
-[discrete]


Good job for updating the dev guide.

jeffryhartanto · 2017-10-14T12:06:14Z

docs/UserGuide.adoc

-* *Delete* : `delete INDEX` +
-e.g. `delete 3`
+* *Delete* : `delete INDEX` or `del NAME` +
+e.g. `delete 3`, `del john`


Good job for updating the UserGuide.

jeffryhartanto · 2017-10-14T12:08:56Z

src/main/java/seedu/address/commons/util/StringUtil.java

+     * Will return false for any other non-alphabet string input
+     * e.g. empty string, " abc " (untrimmed), "1 a" (contains number)
+     * Will return false if the input string case does not match the string stored (case sensitive)
+     * @throws NullPointerException if {@code s} is null.


Good job for writing the comment

jeffryhartanto · 2017-10-14T12:09:13Z

src/main/java/seedu/address/logic/commands/DeleteAltCommand.java

+import seedu.address.model.person.ReadOnlyPerson;
+import seedu.address.model.person.exceptions.PersonNotFoundException;
+// import seedu.address.commons.core.EventsCenter;
+// import seedu.address.commons.events.logic.ContactAltDeletionEvent;


Can remove commented code.

jeffryhartanto · 2017-10-14T12:17:27Z

src/main/java/seedu/address/model/person/DetailsContainsPredicate.java

+    }
+
+    @Override
+    public boolean test(ReadOnlyPerson person) {


May be can apply abstraction here.

jeffryhartanto · 2017-10-14T12:17:58Z

src/main/java/seedu/address/ui/UiManager.java

+    // private void handleContactDeletionEvent(ContactAltDeletionEvent event) {
+    // logger.info(LogsCenter.getEventHandlingLogMessage(event));
+    // showDeleteOperationAlertAndWait();
+    // }


Can remove commented code.

jeffryhartanto · 2017-10-14T12:18:21Z

src/test/java/guitests/WarningDialogGuiTest.java

+// assertEquals(DELETE_WARNING_DIALOG_CONTENT_MESSAGE, alertDialog.getContentText());
+// }
+//
+// }


Can remove commented code.

jeffryhartanto · 2017-10-14T12:18:50Z

src/test/java/seedu/address/logic/commands/DeleteAltCommandTest.java

+/**
+ * Contains integration tests (interaction with the Model) and unit tests for {@code DeleteCommand}.
+ */
+public class DeleteAltCommandTest {


Good job for writing the test cases.

jeffryhartanto · 2017-10-14T12:19:13Z

src/test/java/seedu/address/logic/commands/FindCommandTest.java

-        String expectedMessage = String.format(MESSAGE_PERSONS_LISTED_OVERVIEW, 0);
-        FindCommand command = prepareCommand(" ");
-        assertCommandSuccess(command, expectedMessage, Collections.emptyList());
+    public void equals_indFuzzyFind() {


Good job for updating the test cases.

jeffryhartanto · 2017-10-14T12:22:40Z

@Hailinx @qihao27 @valensia0711 @aaronyhsoh Some comments added.
Good job for passing team component v1.1 milestone. Don't forget to merge your changes for the next milestone.

jeffryhartanto · 2017-10-21T14:08:13Z

@Hailinx @qihao27 @aaronyhsoh @valensia0711
Feedback for Implementation section

3.1. Find mechanism

Typo: in in its arguments.
There are three steps for parsing commands with options <- better explained using sequence diagram.
Can explain what is optional behavior.

3.3. Sort mechanism

This is a very small enhancement and explaining how the sort is implemented is not necessary.
Try to explain larger feature, may be sort by any attribute.

3.4. Lock/Unlock mechanism

Some explanation are not useful.
Can use a sequence diagram for better explanation.

…eek-10 Week 10 enhancements merged

Implemented multi-delete for persons, added schedule list panel, added some tests

Update docs and UI

Update User Guide

Update method names

Rectify style issue

Add new command: export

Collate codes

Update branch

Update docs

Final update

nus-se-pr-bot added team.B1 tutorial.T10 labels Oct 5, 2017

nus-se-pr-bot assigned jeffryhartanto Oct 5, 2017

jeffryhartanto reviewed Oct 7, 2017

View reviewed changes

jeffryhartanto added the reviewed-v1_0 label Oct 7, 2017

jeffryhartanto reviewed Oct 14, 2017

View reviewed changes

jeffryhartanto added reviewed-v1_1 reviewed-v1_2 labels Oct 21, 2017

ChenXiaoman pushed a commit to ChenXiaoman/Weaver that referenced this pull request Oct 24, 2017

Merge pull request nus-cs2103-AY1718S1#70 from CS2103AUG2017-W13-B2/w…

9286a59

…eek-10 Week 10 enhancements merged

Hailinx changed the title ~~[W7.7][T10-B1] AddressBook~~ [W7.7][T10-B1] AcquaNote Oct 26, 2017

cjianhui added a commit to cjianhui/main that referenced this pull request Oct 27, 2017

Merge pull request nus-cs2103-AY1718S1#70 from Procrastinatus/master

417feec

Implemented multi-delete for persons, added schedule list panel, added some tests

Hailinx and others added 16 commits October 29, 2017 00:37

Merge pull request #59 from qihao27/master

d5c276e

Update docs and UI

Edit build.gradle fro building jar file

c8699f6

Enhance Select command

865e823

Update code style

a536a2b

Merge branch 'master' into master

d004ecd

Add export command

8f7ec4b

Add Junit Test

265e2fa

Update User Guide

Merge branch 'master' into master

ea8c7de

Update ExportCommandTest.java

d1e18ff

Update method names

Update ExportCommandParserTest.java

9dc41eb

Rectify style issue

Merge pull request #63 from qihao27/master

ea73f3b

Add new command: export

Update docs: update roles, README, sort implementation

d79ca10

Merge branch 'master' of https://github.com/qihao27/addressbook-level4

463cf95

Merge branch 'master' into master

9e2ed9b

Add collate comment

ae823b0

Rectify style issue

937b22b

Collate codes

qihao27 and others added 25 commits November 13, 2017 18:12

Update AboutUs, PPP, TestScript

90bbd1d

Merge pull request #6 from CS2103AUG2017-T10-B1/master

1e1bd27

Update branch

Merge branch 'master' of https://github.com/qihao27/addressbook-level4

60a65aa

Add portfolio link

597a96f

Merge pull request #123 from qihao27/master

90ce45e

Update docs

Update developer guide

4cda218

Update UG (undo and redo enhanced)

85d52cb

Update UG (rewrite enhanced redo and undo)

eaab96a

Update UG (redocomand)

ebb8220

Update UG formatting

4241a2c

Final update

b7f234b

Merge branch 'master' into master

f81a95e

Merge branch 'master' into master

2b76c29

Add valensia's PPP

e8967b9

Rename Valensia Sebastiani to Valensia Sebastiani.adoc

c234d83

Rectifying Travis checkstyle error

f9ebcc1

Update PPP

bddd037

Update AaronSoh.adoc

050be77

Update UserGuide.adoc

9c73223

Update AaronSoh.adoc

18416c7

Update AaronSoh.adoc

8b592f4

Update DeveloperGuide.adoc

70a3cf0

Update AaronSoh.adoc

09a71db

Update AaronSoh.adoc

faf6696

Update UserGuide.adoc

e16ce3a

damithc closed this Nov 13, 2017

aaronyhsoh added 3 commits November 13, 2017 21:41

Update AaronSoh.adoc

41a8f10

Update AaronSoh.adoc

91153f2

Merge pull request #125 from aaronyhsoh/master

5b75d32

Final update

damithc reopened this Nov 13, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[W7.7][T10-B1] AcquaiNote #70

[W7.7][T10-B1] AcquaiNote #70

Hailinx commented Oct 5, 2017

jeffryhartanto Oct 7, 2017

jeffryhartanto Oct 7, 2017

jeffryhartanto Oct 7, 2017

jeffryhartanto Oct 7, 2017

jeffryhartanto Oct 7, 2017

jeffryhartanto Oct 7, 2017

jeffryhartanto Oct 7, 2017

jeffryhartanto Oct 7, 2017

jeffryhartanto Oct 7, 2017

jeffryhartanto Oct 7, 2017

jeffryhartanto commented Oct 7, 2017

jeffryhartanto Oct 14, 2017

jeffryhartanto Oct 14, 2017

jeffryhartanto Oct 14, 2017

jeffryhartanto Oct 14, 2017

jeffryhartanto Oct 14, 2017

jeffryhartanto Oct 14, 2017

jeffryhartanto Oct 14, 2017

jeffryhartanto Oct 14, 2017

jeffryhartanto Oct 14, 2017

jeffryhartanto Oct 14, 2017

jeffryhartanto commented Oct 14, 2017

jeffryhartanto commented Oct 21, 2017

		@@ -729,8 +729,26 @@ Priorities: High (must have) - `* * \`, Medium (nice to have) - ` \*`, Low (un

		\|`* * *` \|user \|find a person by name \|locate details of persons without having to go through the entire list

		\|`* * *` \|user \|add details to a certain contact after adding them \|have more information available afterwards

		\|`* *` \|user \|hide link:#private-contact-detail[private contact details] by default \|minimize chance of someone else seeing them by accident

		\|`* *` \|user \|use link:#right-click-menu[right click menu] for most link:#common-commands[common commands] \|no typing is required and makes my life easy


		\|`* * *` \|user \|show list of favourite contacts \|quickly find people I contact often

		\|`* * *` \|user \|be notified when entering user with same name \|avoid confusion in the future


		\|`* * *` \|user \|have a more flexible addition of contact \|add contacts without address or email as compulsory elements

		\|`* * *` \|user \|show list of favourite contacts \|quickly find people I contact often

[W7.7][T10-B1] AcquaiNote #70

Are you sure you want to change the base?

[W7.7][T10-B1] AcquaiNote #70

Conversation

Hailinx commented Oct 5, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jeffryhartanto commented Oct 7, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jeffryhartanto commented Oct 14, 2017

jeffryhartanto commented Oct 21, 2017