[W6.4d][F09-B4]Zhong ZhengXin #731
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k-l-a
reviewed
Mar 18, 2018
|
|
||
| public abstract boolean isMutating( ); | ||
| /** | ||
| * Checks whether the commands change the data |
There was a problem hiding this comment.
A more precise phrasing would be Returns true if.....
It is better to mention that it returns true if the command potentially changes the data. Try to be as precise as possible.
| @@ -90,7 +91,10 @@ private void assertCommandBehavior(String inputCommand, | |||
| //Confirm the state of data is as expected | |||
| assertEquals(expectedAddressBook, addressBook); | |||
| assertEquals(lastShownList, logic.getLastShownList()); | |||
| assertEquals(addressBook, saveFile.load()); | |||
| if(new Parser().parseCommand(inputCommand).isMutating()) { | |||
There was a problem hiding this comment.
This change does not help as it does not confirm that saving happens only on mutating commands. Tests will pass even without this change. To be more complete, you should have an else branch to confirm that saving does not happen if the command is non mutating.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Polymorphism [LO-Polymorphism]:
Exercise: Add a polymorphic isMutating method