[v1.4][T11-B4] TravelBanker #55
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chen Chongsong Enhancement
Revert "Chen Chongsong Enhancement"
* added currency balance check * added collated files * style changes * style changes * style changes * currency command test style * changed parser * changed parser * changed parser
* added currency balance check * added collated files * style changes * style changes * style changes * currency command test style * changed parser * changed parser * changed parser * added undoable functionaltiy for wipe
* update portfolio links * updatebadge * allow only positive money to pass through splitCommand
* allow only positive money to pass through splitCommand * fix itemadd messages * fix itemdelete bug * update userguide for sort
* Add some tests * Add more tests
…edu#166) * update portfolio links * updatebadge * allow only positive money to pass through splitCommand * fix itemadd messages * fix itemdelete bug * update userguide for sort * update badges * add tests for itemshowcommandparser * update tests * update tests format * add tests for removetagscommandparser * add sortcommandparsertest
* add tests for split command * add test for itemaddcommand parser * travis * collate
* Updated userguide to include balance feature * Updated Coming in V2.0 features * Updated Developper Guide for Balance feature * Updated Userguide. Included new v2.0 feature * Added features coming in V2.0 * Updated summary of commands including v2.0 features * Deleted Learning Outcome Page * Modified documentation to exclude references to AddressBook * Added Running Test Section * Added Interest Rate feature to UserGuide * Added User Stories according to v2.0 * Updated user stories * Changed Double to double in Money class * Changed reference Addressbook to Travel Banker in Money class * Updated Userguide Story for Select command to load google search for nearby ATM * Added Feature contribution section and modified Value proposition following TA's comments * Added feature contribution about select method * Balance command now works * Added two decimal places formatting for balance feature * Improved formatting * Preparing to write test * Added test for Balance Comand * Updated Comamnd Test * Started to describe balance feature in developper guide * Added Class Diagram in Balance Implementation * Included Sequence Diagram for documentation of Balance feature * Sequence Diagram updated * Added activity diagram for balance command * Updated balance feature documentation * Finished documentation for balance command * Added encryption tag to pass gradle * Added encryption tag to pass gradle * style error * fixing gradle * Style changes to pass travis * Fixing checkstyle for travis * Updated Balance Command styles to pass travis * Added Usage message to BalanceCommand & incorporated MinCommand * Added find Min Command * Updated documentation * Gradle bulid passed * Fixed MinFeature to not display anything if all balances are positive * Gradle Build passed * Removed trailing whitespace * Removed trailing whitespace * Allowed Select page to search for nearby ATM * Loads search for nearest atm upon launch * Changed Browser Panel * Modified so that default page is a search for nearest ATM. Tests comply * All tests have passed * Style corrections * Added MapCommand * Added Command recogniztion test for MapCommand * Map Command Tests Pass * Corrected some imports * Added javadoc * Fixed Checkstyle * Updated UI Mockup in ReadMe * Corrected UI Mockup * changed version number in main app * Select Command now searches for person's address * Selection works * Map functionality passes tests * Collated Code for Articho28 * Collated * user guide checked * Modified collated code * Finished collating * to pass Travis * modified version number * Checkstyle * Updated userguide * Updated UserGuide * Updated UsergUide * Changed version number * All tags now have a new color * Attempting changes * ColorTag does not change the color yet * Added isValidColor in Parser UTIL * Command now recognized. Missing color changing part * Removed ColorTagCommand for SearchTagCommand * Search Tag Command works * Formatted feeback to user * Collating code * Updated UserGuide * Single Input Test Passed * All Test Pased * fixed checkstyle * Updated Collated Code * Updated Collated Code * Project Portfolio page started Articho28 * Personal Portfolio page finished * Added Code Contribution * Fixing trailing whitespace * Fixing badge in REadme.adoc * Revert to old badge * Revert to addressbooklvl badge * Updated documentation to clearly indicate balances, and changed names of max and min commands * Modified default addressbook * Started writing tests * Added test for MinCommand * Added MinCommandTest * Merged tests for min command * updated Collated Code * Fixed checkstyle
* Updated userguide to include balance feature * Updated Coming in V2.0 features * Updated Developper Guide for Balance feature * Updated Userguide. Included new v2.0 feature * Added features coming in V2.0 * Updated summary of commands including v2.0 features * Deleted Learning Outcome Page * Modified documentation to exclude references to AddressBook * Added Running Test Section * Added Interest Rate feature to UserGuide * Added User Stories according to v2.0 * Updated user stories * Changed Double to double in Money class * Changed reference Addressbook to Travel Banker in Money class * Updated Userguide Story for Select command to load google search for nearby ATM * Added Feature contribution section and modified Value proposition following TA's comments * Added feature contribution about select method * Balance command now works * Added two decimal places formatting for balance feature * Improved formatting * Preparing to write test * Added test for Balance Comand * Updated Comamnd Test * Started to describe balance feature in developper guide * Added Class Diagram in Balance Implementation * Included Sequence Diagram for documentation of Balance feature * Sequence Diagram updated * Added activity diagram for balance command * Updated balance feature documentation * Finished documentation for balance command * Added encryption tag to pass gradle * Added encryption tag to pass gradle * style error * fixing gradle * Style changes to pass travis * Fixing checkstyle for travis * Updated Balance Command styles to pass travis * Added Usage message to BalanceCommand & incorporated MinCommand * Added find Min Command * Updated documentation * Gradle bulid passed * Fixed MinFeature to not display anything if all balances are positive * Gradle Build passed * Removed trailing whitespace * Removed trailing whitespace * Allowed Select page to search for nearby ATM * Loads search for nearest atm upon launch * Changed Browser Panel * Modified so that default page is a search for nearest ATM. Tests comply * All tests have passed * Style corrections * Added MapCommand * Added Command recogniztion test for MapCommand * Map Command Tests Pass * Corrected some imports * Added javadoc * Fixed Checkstyle * Updated UI Mockup in ReadMe * Corrected UI Mockup * changed version number in main app * Select Command now searches for person's address * Selection works * Map functionality passes tests * Collated Code for Articho28 * Collated * user guide checked * Modified collated code * Finished collating * to pass Travis * modified version number * Checkstyle * Updated userguide * Updated UserGuide * Updated UsergUide * Changed version number * All tags now have a new color * Attempting changes * ColorTag does not change the color yet * Added isValidColor in Parser UTIL * Command now recognized. Missing color changing part * Removed ColorTagCommand for SearchTagCommand * Search Tag Command works * Formatted feeback to user * Collating code * Updated UserGuide * Single Input Test Passed * All Test Pased * fixed checkstyle * Updated Collated Code * Updated Collated Code * Project Portfolio page started Articho28 * Personal Portfolio page finished * Added Code Contribution * Fixing trailing whitespace * Fixing badge in REadme.adoc * Revert to old badge * Revert to addressbooklvl badge * Updated documentation to clearly indicate balances, and changed names of max and min commands * Modified default addressbook * Started writing tests * Added test for MinCommand * Added MinCommandTest * Merged tests for min command * updated Collated Code * Fixed checkstyle * Added an exception to searchtag * Added Test for SearchCommandParser: * Added Collated Code * checkstylecorrections * Fixed typo in documentation * updated personal portfolio page * fixed merge issues in documentation * Corrected my personal portofolio page and modified documentation * Minor documentation fix * updated mockup * updated mockup * updated mockup
…#171) * Updated userguide to include balance feature * Updated Coming in V2.0 features * Updated Developper Guide for Balance feature * Updated Userguide. Included new v2.0 feature * Added features coming in V2.0 * Updated summary of commands including v2.0 features * Deleted Learning Outcome Page * Modified documentation to exclude references to AddressBook * Added Running Test Section * Added Interest Rate feature to UserGuide * Added User Stories according to v2.0 * Updated user stories * Changed Double to double in Money class * Changed reference Addressbook to Travel Banker in Money class * Updated Userguide Story for Select command to load google search for nearby ATM * Added Feature contribution section and modified Value proposition following TA's comments * Added feature contribution about select method * Balance command now works * Added two decimal places formatting for balance feature * Improved formatting * Preparing to write test * Added test for Balance Comand * Updated Comamnd Test * Started to describe balance feature in developper guide * Added Class Diagram in Balance Implementation * Included Sequence Diagram for documentation of Balance feature * Sequence Diagram updated * Added activity diagram for balance command * Updated balance feature documentation * Finished documentation for balance command * Added encryption tag to pass gradle * Added encryption tag to pass gradle * style error * fixing gradle * Style changes to pass travis * Fixing checkstyle for travis * Updated Balance Command styles to pass travis * Added Usage message to BalanceCommand & incorporated MinCommand * Added find Min Command * Updated documentation * Gradle bulid passed * Fixed MinFeature to not display anything if all balances are positive * Gradle Build passed * Removed trailing whitespace * Removed trailing whitespace * Allowed Select page to search for nearby ATM * Loads search for nearest atm upon launch * Changed Browser Panel * Modified so that default page is a search for nearest ATM. Tests comply * All tests have passed * Style corrections * Added MapCommand * Added Command recogniztion test for MapCommand * Map Command Tests Pass * Corrected some imports * Added javadoc * Fixed Checkstyle * Updated UI Mockup in ReadMe * Corrected UI Mockup * changed version number in main app * Select Command now searches for person's address * Selection works * Map functionality passes tests * Collated Code for Articho28 * Collated * user guide checked * Modified collated code * Finished collating * to pass Travis * modified version number * Checkstyle * Updated userguide * Updated UserGuide * Updated UsergUide * Changed version number * All tags now have a new color * Attempting changes * ColorTag does not change the color yet * Added isValidColor in Parser UTIL * Command now recognized. Missing color changing part * Removed ColorTagCommand for SearchTagCommand * Search Tag Command works * Formatted feeback to user * Collating code * Updated UserGuide * Single Input Test Passed * All Test Pased * fixed checkstyle * Updated Collated Code * Updated Collated Code * Project Portfolio page started Articho28 * Personal Portfolio page finished * Added Code Contribution * Fixing trailing whitespace * Fixing badge in REadme.adoc * Revert to old badge * Revert to addressbooklvl badge * Updated documentation to clearly indicate balances, and changed names of max and min commands * Modified default addressbook * Started writing tests * Added test for MinCommand * Added MinCommandTest * Merged tests for min command * updated Collated Code * Fixed checkstyle * Added an exception to searchtag * Added Test for SearchCommandParser: * Added Collated Code * checkstylecorrections * Fixed typo in documentation * updated personal portfolio page * fixed merge issues in documentation * Corrected my personal portofolio page and modified documentation * Minor documentation fix * updated mockup * updated mockup * updated mockup * added test to SearchTagCommand Parser
* Updated userguide to include balance feature * Updated Coming in V2.0 features * Updated Developper Guide for Balance feature * Updated Userguide. Included new v2.0 feature * Added features coming in V2.0 * Updated summary of commands including v2.0 features * Deleted Learning Outcome Page * Modified documentation to exclude references to AddressBook * Added Running Test Section * Added Interest Rate feature to UserGuide * Added User Stories according to v2.0 * Updated user stories * Changed Double to double in Money class * Changed reference Addressbook to Travel Banker in Money class * Updated Userguide Story for Select command to load google search for nearby ATM * Added Feature contribution section and modified Value proposition following TA's comments * Added feature contribution about select method * Balance command now works * Added two decimal places formatting for balance feature * Improved formatting * Preparing to write test * Added test for Balance Comand * Updated Comamnd Test * Started to describe balance feature in developper guide * Added Class Diagram in Balance Implementation * Included Sequence Diagram for documentation of Balance feature * Sequence Diagram updated * Added activity diagram for balance command * Updated balance feature documentation * Finished documentation for balance command * Added encryption tag to pass gradle * Added encryption tag to pass gradle * style error * fixing gradle * Style changes to pass travis * Fixing checkstyle for travis * Updated Balance Command styles to pass travis * Added Usage message to BalanceCommand & incorporated MinCommand * Added find Min Command * Updated documentation * Gradle bulid passed * Fixed MinFeature to not display anything if all balances are positive * Gradle Build passed * Removed trailing whitespace * Removed trailing whitespace * Allowed Select page to search for nearby ATM * Loads search for nearest atm upon launch * Changed Browser Panel * Modified so that default page is a search for nearest ATM. Tests comply * All tests have passed * Style corrections * Added MapCommand * Added Command recogniztion test for MapCommand * Map Command Tests Pass * Corrected some imports * Added javadoc * Fixed Checkstyle * Updated UI Mockup in ReadMe * Corrected UI Mockup * changed version number in main app * Select Command now searches for person's address * Selection works * Map functionality passes tests * Collated Code for Articho28 * Collated * user guide checked * Modified collated code * Finished collating * to pass Travis * modified version number * Checkstyle * Updated userguide * Updated UserGuide * Updated UsergUide * Changed version number * All tags now have a new color * Attempting changes * ColorTag does not change the color yet * Added isValidColor in Parser UTIL * Command now recognized. Missing color changing part * Removed ColorTagCommand for SearchTagCommand * Search Tag Command works * Formatted feeback to user * Collating code * Updated UserGuide * Single Input Test Passed * All Test Pased * fixed checkstyle * Updated Collated Code * Updated Collated Code * Project Portfolio page started Articho28 * Personal Portfolio page finished * Added Code Contribution * Fixing trailing whitespace * Fixing badge in REadme.adoc * Revert to old badge * Revert to addressbooklvl badge * Updated documentation to clearly indicate balances, and changed names of max and min commands * Modified default addressbook * Started writing tests * Added test for MinCommand * Added MinCommandTest * Merged tests for min command * updated Collated Code * Fixed checkstyle * Added an exception to searchtag * Added Test for SearchCommandParser: * Added Collated Code * checkstylecorrections * Fixed typo in documentation * updated personal portfolio page * fixed merge issues in documentation * Corrected my personal portofolio page and modified documentation * Minor documentation fix * updated mockup * updated mockup * updated mockup * added test to SearchTagCommand Parser * Uploaded updated Mockup * fixed mockup
* Updated userguide to include balance feature * Updated Coming in V2.0 features * Updated Developper Guide for Balance feature * Updated Userguide. Included new v2.0 feature * Added features coming in V2.0 * Updated summary of commands including v2.0 features * Deleted Learning Outcome Page * Modified documentation to exclude references to AddressBook * Added Running Test Section * Added Interest Rate feature to UserGuide * Added User Stories according to v2.0 * Updated user stories * Changed Double to double in Money class * Changed reference Addressbook to Travel Banker in Money class * Updated Userguide Story for Select command to load google search for nearby ATM * Added Feature contribution section and modified Value proposition following TA's comments * Added feature contribution about select method * Balance command now works * Added two decimal places formatting for balance feature * Improved formatting * Preparing to write test * Added test for Balance Comand * Updated Comamnd Test * Started to describe balance feature in developper guide * Added Class Diagram in Balance Implementation * Included Sequence Diagram for documentation of Balance feature * Sequence Diagram updated * Added activity diagram for balance command * Updated balance feature documentation * Finished documentation for balance command * Added encryption tag to pass gradle * Added encryption tag to pass gradle * style error * fixing gradle * Style changes to pass travis * Fixing checkstyle for travis * Updated Balance Command styles to pass travis * Added Usage message to BalanceCommand & incorporated MinCommand * Added find Min Command * Updated documentation * Gradle bulid passed * Fixed MinFeature to not display anything if all balances are positive * Gradle Build passed * Removed trailing whitespace * Removed trailing whitespace * Allowed Select page to search for nearby ATM * Loads search for nearest atm upon launch * Changed Browser Panel * Modified so that default page is a search for nearest ATM. Tests comply * All tests have passed * Style corrections * Added MapCommand * Added Command recogniztion test for MapCommand * Map Command Tests Pass * Corrected some imports * Added javadoc * Fixed Checkstyle * Updated UI Mockup in ReadMe * Corrected UI Mockup * changed version number in main app * Select Command now searches for person's address * Selection works * Map functionality passes tests * Collated Code for Articho28 * Collated * user guide checked * Modified collated code * Finished collating * to pass Travis * modified version number * Checkstyle * Updated userguide * Updated UserGuide * Updated UsergUide * Changed version number * All tags now have a new color * Attempting changes * ColorTag does not change the color yet * Added isValidColor in Parser UTIL * Command now recognized. Missing color changing part * Removed ColorTagCommand for SearchTagCommand * Search Tag Command works * Formatted feeback to user * Collating code * Updated UserGuide * Single Input Test Passed * All Test Pased * fixed checkstyle * Updated Collated Code * Updated Collated Code * Project Portfolio page started Articho28 * Personal Portfolio page finished * Added Code Contribution * Fixing trailing whitespace * Fixing badge in REadme.adoc * Revert to old badge * Revert to addressbooklvl badge * Updated documentation to clearly indicate balances, and changed names of max and min commands * Modified default addressbook * Started writing tests * Added test for MinCommand * Added MinCommandTest * Merged tests for min command * updated Collated Code * Fixed checkstyle * Added an exception to searchtag * Added Test for SearchCommandParser: * Added Collated Code * checkstylecorrections * Fixed typo in documentation * updated personal portfolio page * fixed merge issues in documentation * Corrected my personal portofolio page and modified documentation * Minor documentation fix * updated mockup * updated mockup * updated mockup * added test to SearchTagCommand Parser * Uploaded updated Mockup * fixed mockup * Updated documentation regarding internet connectivity * updated maxborrowed command documentation * Fixed add and edit money message contraint * Updated documenation about behavior of maxlent and maxborrowed commands * Limited input for money to 16 digits * Updated Personal Project Portolio * Fixed settle command to throw exception if balance is already 0 * Made debt command disregard contacts with 0 * Made debt command disregard contacts with 0 * Added exception handling for invalid currency input for convert command * fix checkstyle
* Updated userguide to include balance feature * Updated Coming in V2.0 features * Updated Developper Guide for Balance feature * Updated Userguide. Included new v2.0 feature * Added features coming in V2.0 * Updated summary of commands including v2.0 features * Deleted Learning Outcome Page * Modified documentation to exclude references to AddressBook * Added Running Test Section * Added Interest Rate feature to UserGuide * Added User Stories according to v2.0 * Updated user stories * Changed Double to double in Money class * Changed reference Addressbook to Travel Banker in Money class * Updated Userguide Story for Select command to load google search for nearby ATM * Added Feature contribution section and modified Value proposition following TA's comments * Added feature contribution about select method * Balance command now works * Added two decimal places formatting for balance feature * Improved formatting * Preparing to write test * Added test for Balance Comand * Updated Comamnd Test * Started to describe balance feature in developper guide * Added Class Diagram in Balance Implementation * Included Sequence Diagram for documentation of Balance feature * Sequence Diagram updated * Added activity diagram for balance command * Updated balance feature documentation * Finished documentation for balance command * Added encryption tag to pass gradle * Added encryption tag to pass gradle * style error * fixing gradle * Style changes to pass travis * Fixing checkstyle for travis * Updated Balance Command styles to pass travis * Added Usage message to BalanceCommand & incorporated MinCommand * Added find Min Command * Updated documentation * Gradle bulid passed * Fixed MinFeature to not display anything if all balances are positive * Gradle Build passed * Removed trailing whitespace * Removed trailing whitespace * Allowed Select page to search for nearby ATM * Loads search for nearest atm upon launch * Changed Browser Panel * Modified so that default page is a search for nearest ATM. Tests comply * All tests have passed * Style corrections * Added MapCommand * Added Command recogniztion test for MapCommand * Map Command Tests Pass * Corrected some imports * Added javadoc * Fixed Checkstyle * Updated UI Mockup in ReadMe * Corrected UI Mockup * changed version number in main app * Select Command now searches for person's address * Selection works * Map functionality passes tests * Collated Code for Articho28 * Collated * user guide checked * Modified collated code * Finished collating * to pass Travis * modified version number * Checkstyle * Updated userguide * Updated UserGuide * Updated UsergUide * Changed version number * All tags now have a new color * Attempting changes * ColorTag does not change the color yet * Added isValidColor in Parser UTIL * Command now recognized. Missing color changing part * Removed ColorTagCommand for SearchTagCommand * Search Tag Command works * Formatted feeback to user * Collating code * Updated UserGuide * Single Input Test Passed * All Test Pased * fixed checkstyle * Updated Collated Code * Updated Collated Code * Project Portfolio page started Articho28 * Personal Portfolio page finished * Added Code Contribution * Fixing trailing whitespace * Fixing badge in REadme.adoc * Revert to old badge * Revert to addressbooklvl badge * Updated documentation to clearly indicate balances, and changed names of max and min commands * Modified default addressbook * Started writing tests * Added test for MinCommand * Added MinCommandTest * Merged tests for min command * updated Collated Code * Fixed checkstyle * Added an exception to searchtag * Added Test for SearchCommandParser: * Added Collated Code * checkstylecorrections * Fixed typo in documentation * updated personal portfolio page * fixed merge issues in documentation * Corrected my personal portofolio page and modified documentation * Minor documentation fix * updated mockup * updated mockup * updated mockup * added test to SearchTagCommand Parser * Uploaded updated Mockup * fixed mockup * Updated documentation regarding internet connectivity * updated maxborrowed command documentation * Fixed add and edit money message contraint * Updated documenation about behavior of maxlent and maxborrowed commands * Limited input for money to 16 digits * Updated Personal Project Portolio * Fixed settle command to throw exception if balance is already 0 * Made debt command disregard contacts with 0 * Made debt command disregard contacts with 0 * Added exception handling for invalid currency input for convert command * fix checkstyle * Updated collation
* added Tests for list balances * method name change * style changes * added whitespace around - * added collated files * whitespace * edited tests * modified collated files
* Update DeveloperGuide.adoc * Update DeveloperGuide.adoc * Update DeveloperGuide.adoc
* Update software-1234.adoc * Update software-1234.adoc * Update software-1234.adoc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.