Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CS2103T-T17-1] RHRH #150

Open
wants to merge 656 commits into
base: master
Choose a base branch
from
Open
Changes from 11 commits
Commits
Show all changes
656 commits
Select commit Hold shift + click to select a range
a3492ef
Merge branch 'master' of https://github.com/clementkfj/tp into branch…
clementkfj Nov 2, 2021
7518012
Merge pull request #177 from clementkfj/branch-PE-Issues
Javiier-pzk Nov 2, 2021
13bc351
Update UserGuide.md
Javiier-pzk Nov 2, 2021
04555c4
Improve JUnit test for ResetSupplier/Customer/EmployeeSortCommand cla…
Javiier-pzk Nov 2, 2021
1eac3d2
Add more test cases to SortSupplierCommandParser class
Javiier-pzk Nov 2, 2021
af4bb87
Merge pull request #180 from Javiier-pzk/branch-sorting-JUnit-tests
clementkfj Nov 2, 2021
855ce34
Add Test cases and Fix CommandTestUtil
clementkfj Nov 2, 2021
257c973
Merge branch 'master' into branch-PE-Issues
clementkfj Nov 2, 2021
71c35d4
Fix Loyalty Points
clementkfj Nov 2, 2021
2414178
Fix leaves and UG details
clementkfj Nov 2, 2021
b8ed5e7
Make DateTimes more flexible
Javiier-pzk Nov 2, 2021
d0b811c
Merge pull request #181 from clementkfj/branch-PE-Issues
clementkfj Nov 2, 2021
265c86b
Merge pull request #182 from Javiier-pzk/branch-sorting-JUnit-tests
clementkfj Nov 2, 2021
43fdd10
change all instance of SPECIALREQUEST to SPECIAL_REQUEST
chetwinlow Nov 2, 2021
8e8bcb1
Add Test cases for Find
clementkfj Nov 2, 2021
fe26ce1
Merge pull request #186 from clementkfj/branch-Employee-testing
Javiier-pzk Nov 2, 2021
4ef98b4
change all instance of SPECIALREQUEST to SPECIAL_REQUEST, plus reform…
chetwinlow Nov 2, 2021
a4b1936
change all instance of SPECIALREQUEST to SPECIAL_REQUEST, plus reform…
chetwinlow Nov 2, 2021
4e840fc
change all instance of SPECIALREQUEST to SPECIAL_REQUEST, plus reform…
chetwinlow Nov 2, 2021
7f907c0
Merge pull request #183 from chetwinlow/branch-special-request-format…
Javiier-pzk Nov 2, 2021
fa756bd
Add JUnit tests for FindSupplierCommand and FindSupplierCommandParser…
Javiier-pzk Nov 2, 2021
bde8d26
Remove unused regex checkers
Javiier-pzk Nov 2, 2021
c125ff6
WOOHOO test casesssss
chetwinlow Nov 2, 2021
1c664e0
WOOHOO test casesssss
chetwinlow Nov 2, 2021
263c9f9
WOOHOO test casesssss
chetwinlow Nov 2, 2021
654fa23
Merge pull request #191 from Javiier-pzk/branch-findSupplier-JUnit-tests
chetwinlow Nov 2, 2021
e5b85d0
Merge branch 'master' into branch-sort-customer-testcases
chetwinlow Nov 2, 2021
fc76c1e
WOOHOO test casesssss
chetwinlow Nov 2, 2021
ea0b245
Merge remote-tracking branch 'origin/branch-sort-customer-testcases' …
chetwinlow Nov 2, 2021
d63188c
Merge pull request #189 from chetwinlow/branch-sort-customer-testcases
Javiier-pzk Nov 2, 2021
0b4802c
add flexible date time parse for reservation
pbthang Nov 3, 2021
745b6af
fix CI failed
pbthang Nov 3, 2021
f04e8cf
Merge pull request #192 from pbthang/UG-update
clementkfj Nov 3, 2021
6e29982
add test for edit reservation command
pbthang Nov 3, 2021
ca28f95
Merge branch 'master' of https://github.com/AY2122S1-CS2103T-T17-1/tp
hernpiblo Nov 3, 2021
c1589b3
add test cases for edit reservation command
pbthang Nov 3, 2021
52a6b9f
Merge branch 'master' of https://github.com/pbthang/tp into reservati…
pbthang Nov 3, 2021
10b7386
Merge pull request #195 from pbthang/reservation-test
clementkfj Nov 3, 2021
1d450ea
Add PPP and fix error messages
clementkfj Nov 3, 2021
49b6864
Fix bugs
clementkfj Nov 3, 2021
f06772d
End of Line
clementkfj Nov 3, 2021
007bbff
Remove _
clementkfj Nov 3, 2021
e3157d8
Remove line for Javier
clementkfj Nov 3, 2021
18e60ea
Change User guide to be non developer brained
clementkfj Nov 3, 2021
14af3cf
Merge pull request #197 from clementkfj/branch-1.4-Bugs
Javiier-pzk Nov 3, 2021
718f639
Update UG
Javiier-pzk Nov 4, 2021
b166679
Update README.md
Javiier-pzk Nov 4, 2021
3152d19
Add overview and info about user guide
Javiier-pzk Nov 4, 2021
cf2d099
Refactor typical reservations and typical tables to another class
hernpiblo Nov 4, 2021
074e6b3
Replace AddressBook with Rhrh
clementkfj Nov 4, 2021
14b5411
Replace readme
clementkfj Nov 4, 2021
00c641c
Merge pull request #199 from hernpiblo/v1.4-test-code-quality
clementkfj Nov 4, 2021
2b08318
Merge branch 'clementkfj-branch-1.4-Bugs'
clementkfj Nov 4, 2021
efcc4e5
Fix conflicts
clementkfj Nov 4, 2021
cc1af55
Merge branch 'master' of https://github.com/AY2122S1-CS2103T-T17-1/tp
hernpiblo Nov 4, 2021
a2f456b
Change address books in UG
clementkfj Nov 4, 2021
72e1891
Merge branch 'master' of https://github.com/pbthang/tp into reservati…
pbthang Nov 4, 2021
baca859
Merge pull request #201 from clementkfj/master
hernpiblo Nov 4, 2021
b41bec0
Merge branch 'master' of https://github.com/AY2122S1-CS2103T-T17-1/tp
hernpiblo Nov 4, 2021
0306a39
Merge branch 'master' of https://github.com/pbthang/tp into reservati…
pbthang Nov 4, 2021
635ff13
Create PPP for javiier-pzk
Javiier-pzk Nov 4, 2021
8720bf2
Merge pull request #202 from Javiier-pzk/branch-PPP-and-documenation
clementkfj Nov 4, 2021
ab20898
Merge branch 'master' of https://github.com/Javiier-pzk/tp
Javiier-pzk Nov 4, 2021
27e826e
Update UserGuide.md
Javiier-pzk Nov 4, 2021
daf3904
Update AboutUs.md
Javiier-pzk Nov 4, 2021
39a1362
Change file name
Javiier-pzk Nov 4, 2021
2635c7d
Revert "Change file name"
Javiier-pzk Nov 4, 2021
580cddb
add PPP for pbthang
pbthang Nov 4, 2021
a594b0e
Rename javiier-pzk PPP file
Javiier-pzk Nov 4, 2021
fb138f7
Merge pull request #203 from Javiier-pzk/branch-PPP-and-documenation
clementkfj Nov 4, 2021
fb31808
Merge branch 'master' of https://github.com/AY2122S1-CS2103T-T17-1/tp
Javiier-pzk Nov 4, 2021
128e4ac
Merge pull request #204 from pbthang/reservation-test
clementkfj Nov 4, 2021
92ef917
Update AboutUs.md
Javiier-pzk Nov 4, 2021
dab5259
Update javiier-pzk.md
Javiier-pzk Nov 4, 2021
53e595e
Edit format in javiier-pzk
Javiier-pzk Nov 4, 2021
7ad7077
Merge branch 'master' of https://github.com/AY2122S1-CS2103T-T17-1/tp
hernpiblo Nov 4, 2021
8869dc0
Merge pull request #205 from Javiier-pzk/branch-PPP-and-documenation
clementkfj Nov 4, 2021
1bc6c15
Shift Documentation to the bottom
Javiier-pzk Nov 4, 2021
3f0a07d
Change formatting
Javiier-pzk Nov 4, 2021
2b6baf0
Fix settables html issue
hernpiblo Nov 4, 2021
1bbd3ff
Merge pull request #206 from Javiier-pzk/branch-PPP-and-documenation
clementkfj Nov 4, 2021
3505b6d
Merge branch 'master' of https://github.com/AY2122S1-CS2103T-T17-1/tp
Javiier-pzk Nov 4, 2021
b45bcd0
Merge pull request #207 from Javiier-pzk/master
pbthang Nov 4, 2021
decbfd2
Update ReadME.md links
Javiier-pzk Nov 4, 2021
673f218
Update javiier-pzk.md
Javiier-pzk Nov 4, 2021
b861139
Merge branch 'master' of https://github.com/AY2122S1-CS2103T-T17-1/tp
hernpiblo Nov 4, 2021
c6dbe4d
First draft of AddEmployee DG
clementkfj Nov 4, 2021
90cdc33
Add EOF
clementkfj Nov 4, 2021
3921d16
Merge pull request #208 from clementkfj/branch-DG-UML
Javiier-pzk Nov 4, 2021
d154a22
Add Sequence diagrams for DeleteSupplier and SortSupplier Commands
Javiier-pzk Nov 4, 2021
7d71a0a
Merge branch 'master' of https://github.com/AY2122S1-CS2103T-T17-1/tp…
Javiier-pzk Nov 4, 2021
d06958e
Add PPP
hernpiblo Nov 4, 2021
224bf79
add class diagram and sequence diagram for reserve command
pbthang Nov 4, 2021
b833c69
Edit deleteSupplier sequence diagram
Javiier-pzk Nov 4, 2021
2fbf6aa
Add DeleteSupplierCommand and SortSupplierCommand class diagram
Javiier-pzk Nov 4, 2021
c8725bd
add new line at EOF
pbthang Nov 4, 2021
7a914ab
Add DeleteSupplier and SortSupplier Implementation in DG
Javiier-pzk Nov 4, 2021
b20adb1
Add settables DG and activity and sequence diagrams
hernpiblo Nov 4, 2021
1b622d3
Merge pull request #210 from pbthang/master
hernpiblo Nov 4, 2021
c8152e0
Reformat paragraphs for DeleteSupplier and SortSupplier in DG
Javiier-pzk Nov 4, 2021
1a04ae9
Add new line at EOF
Javiier-pzk Nov 4, 2021
e239378
Add bug count to javiier-pzk
Javiier-pzk Nov 4, 2021
59c9825
Fix english LOL
Javiier-pzk Nov 4, 2021
42c82c1
Merge pull request #213 from hernpiblo/v1.4-ppp-uml
Javiier-pzk Nov 4, 2021
9c3c9cf
Merge pull request #214 from Javiier-pzk/branch-UML-diagrams
clementkfj Nov 5, 2021
d0fbc85
Update DeveloperGuide.md
clementkfj Nov 5, 2021
8f2b101
Update DeveloperGuide.md
clementkfj Nov 5, 2021
4e933ce
Update DeveloperGuide.md
clementkfj Nov 5, 2021
21a1e41
Improve Diagrams
clementkfj Nov 5, 2021
b61014b
FindCustomerCommandActivityDiagram.puml, FindCustomerCommandSequenceD…
chetwinlow Nov 5, 2021
0b48013
FindCustomerCommandActivityDiagram.puml, FindCustomerCommandSequenceD…
chetwinlow Nov 5, 2021
d49f946
FindCustomerCommandActivityDiagram.puml, FindCustomerCommandSequenceD…
chetwinlow Nov 5, 2021
d05e8c4
FindCustomerCommandActivityDiagram.puml, FindCustomerCommandSequenceD…
chetwinlow Nov 5, 2021
7bc7e42
Merge pull request #217 from clementkfj/branch-DG-UML
Javiier-pzk Nov 5, 2021
4bc38bb
Change picture size
clementkfj Nov 5, 2021
5152b94
Merge pull request #220 from clementkfj/branch-DG-UML
Javiier-pzk Nov 5, 2021
579aa30
Findcustomer section of DG updated, with diagrams and write up
chetwinlow Nov 5, 2021
4263b49
Merge pull request #221 from chetwinlow/branch-find-customer-diagrams
Javiier-pzk Nov 5, 2021
5f57d56
Merge branch 'master' of https://github.com/AY2122S1-CS2103T-T17-1/tp
hernpiblo Nov 5, 2021
669cc58
Reformat the DG and fill in TBC portions of the PPP
hernpiblo Nov 5, 2021
4286a4b
Improve formatting of DG
hernpiblo Nov 5, 2021
ec6f527
Fix settables section in DG
hernpiblo Nov 5, 2021
58f081a
Improve Diagrams and format
clementkfj Nov 5, 2021
dbfb3d4
Fix PPP
clementkfj Nov 5, 2021
6103663
add differences of reserve command in DG
pbthang Nov 5, 2021
5334103
Merge pull request #225 from pbthang/DG-update
clementkfj Nov 5, 2021
ba6d860
Merge pull request #223 from clementkfj/branch-DG-UML
Javiier-pzk Nov 5, 2021
41930d8
Change header from future to alternative implementations
hernpiblo Nov 5, 2021
913623f
Merge pull request #222 from hernpiblo/v1.4-dg-improvement
clementkfj Nov 5, 2021
e795d5e
Add UML note to Delete and Sort sequence diagrams
Javiier-pzk Nov 5, 2021
04d4d1e
Add SortSupplierCommand and DeleteSupplierCommand Activity Diagrams
Javiier-pzk Nov 5, 2021
6e1af28
Update DG with diagrams, reformat diagrams and update javiier-pzk PPP
Javiier-pzk Nov 5, 2021
7d13c6a
Merge pull request #226 from Javiier-pzk/branch-UML-diagrams
Javiier-pzk Nov 5, 2021
54071d5
Update javiier-pzk.md
Javiier-pzk Nov 5, 2021
c5f9275
split Model class diagram into 2 smaller diagrams
pbthang Nov 5, 2021
4bc0a6a
Merge branch 'master' of https://github.com/pbthang/tp into DG-update
pbthang Nov 5, 2021
5946ebb
add get corresponding customer command to DG
pbthang Nov 5, 2021
f870cc9
Updated FindCommand diagrams
chetwinlow Nov 6, 2021
856edc3
Updated EditCommand diagrams
chetwinlow Nov 6, 2021
7ac93f8
fix image error in DG
pbthang Nov 6, 2021
5d2be8d
Updated EditCommand diagrams
chetwinlow Nov 6, 2021
c288e7a
Merge pull request #228 from chetwinlow/branch-update-findcust-diagram
Javiier-pzk Nov 6, 2021
fff88fa
Merge pull request #227 from pbthang/DG-update
chetwinlow Nov 6, 2021
38cdff5
add edit reservation part to DG
pbthang Nov 6, 2021
a76d3e1
Updated FindCommand and EditCommand diagrams and DG
chetwinlow Nov 6, 2021
24070f9
Merge pull request #230 from chetwinlow/branch-find-edit-class-diags
Javiier-pzk Nov 6, 2021
94d09bb
Merge pull request #229 from pbthang/DG-update
Javiier-pzk Nov 6, 2021
5ec5029
added PPP
chetwinlow Nov 6, 2021
e7b03fd
added PPP
chetwinlow Nov 6, 2021
8346f1b
Merge branch 'master' of https://github.com/AY2122S1-CS2103T-T17-1/tp
hernpiblo Nov 6, 2021
a412fd9
added PPP
chetwinlow Nov 6, 2021
511cf79
Merge pull request #231 from chetwinlow/branch-update-ppp
Javiier-pzk Nov 6, 2021
ab3d912
Change activity diagram to standardize
hernpiblo Nov 6, 2021
965f8d1
Update settables sequence diagram to include a note
hernpiblo Nov 6, 2021
23174da
Merge pull request #232 from hernpiblo/v1.4-uml-fix
Javiier-pzk Nov 6, 2021
cbb0a7d
Fix Diagrams for standardisation
clementkfj Nov 6, 2021
a96f933
update sequence diagram for get customer reserving command
pbthang Nov 6, 2021
5802519
Merge pull request #233 from clementkfj/branch-DG-UML
Javiier-pzk Nov 6, 2021
cf83959
Merge branch 'master' of https://github.com/pbthang/tp into DG-update
pbthang Nov 6, 2021
75cfb6d
edit ppp link in AbouUs.md
pbthang Nov 6, 2021
0ca5337
Merge pull request #234 from pbthang/DG-update
Javiier-pzk Nov 6, 2021
1ff6b3a
reformat DG
chetwinlow Nov 6, 2021
71b5da1
Merge pull request #235 from chetwinlow/branch-reformat-DG
Javiier-pzk Nov 6, 2021
6d3026a
Fix bug
clementkfj Nov 6, 2021
d476ae1
reformat DG
chetwinlow Nov 6, 2021
83d439c
Merge branch 'master' of https://github.com/AY2122S1-CS2103T-T17-1/tp…
clementkfj Nov 6, 2021
0704b81
Merge fix
chetwinlow Nov 6, 2021
c6e1ea4
Merge branch 'master' of https://github.com/AY2122S1-CS2103T-T17-1/tp…
chetwinlow Nov 6, 2021
652a631
Merge pull request #237 from chetwinlow/branch-reformat-DG
Javiier-pzk Nov 6, 2021
57ffe2a
Fix format
clementkfj Nov 6, 2021
4e2b920
Merge branch 'master' of https://github.com/AY2122S1-CS2103T-T17-1/tp
hernpiblo Nov 6, 2021
4409a60
Fix formatting
clementkfj Nov 6, 2021
b46479e
Update UserGuide.md
Javiier-pzk Nov 6, 2021
294f056
Update UserGuide.md
Javiier-pzk Nov 6, 2021
c3c8a3b
Final formatting checks
clementkfj Nov 6, 2021
bd01d73
Update UserGuide.md
Javiier-pzk Nov 6, 2021
88ae9fa
Merge pull request #238 from clementkfj/branch-DG-UML
Javiier-pzk Nov 6, 2021
5a41e38
Fix font size for sequence diagrams
hernpiblo Nov 6, 2021
49776d0
Update clementkfj.md
clementkfj Nov 6, 2021
e6ac405
Merge branch 'master' of https://github.com/AY2122S1-CS2103T-T17-1/tp…
hernpiblo Nov 6, 2021
900e9cf
Fix formatting
hernpiblo Nov 6, 2021
fe3762d
Update UserGuide.md
Javiier-pzk Nov 6, 2021
051b922
Merge pull request #239 from hernpiblo/v1.4-uml-font
clementkfj Nov 6, 2021
6bbd2b4
Update UserGuide.md
Javiier-pzk Nov 6, 2021
12d52c5
Update UserGuide.md
Javiier-pzk Nov 6, 2021
f547fa3
Fix uml diagrams
hernpiblo Nov 6, 2021
6a84f66
Fix uml for undoredo
hernpiblo Nov 6, 2021
caed24a
Merge branch 'master' of https://github.com/AY2122S1-CS2103T-T17-1/tp…
hernpiblo Nov 6, 2021
9d4f7ab
Change diagram
hernpiblo Nov 6, 2021
00d51bc
Add javadocs for classes
hernpiblo Nov 6, 2021
e3b0ffb
Merge pull request #240 from hernpiblo/uml-fix2
Javiier-pzk Nov 6, 2021
3bff84f
Merge branch 'master' of https://github.com/AY2122S1-CS2103T-T17-1/tp
hernpiblo Nov 6, 2021
237ebb4
Update DeveloperGuide.md
Javiier-pzk Nov 6, 2021
b0ce806
Update _base.scss
hernpiblo Nov 6, 2021
9177e9d
Merge branch 'master' of https://github.com/AY2122S1-CS2103T-T17-1/tp
hernpiblo Nov 6, 2021
3d486c1
Update hernpiblo.md
hernpiblo Nov 6, 2021
6e6b919
Update UserGuide.md
Javiier-pzk Nov 7, 2021
4f45b93
update test cases for DG
pbthang Nov 7, 2021
0b8424d
Update UserGuide.md
Javiier-pzk Nov 7, 2021
84a3d5c
Add manual testing and use case
clementkfj Nov 7, 2021
77382ed
edit UG and update test case for addr in DG
pbthang Nov 7, 2021
da5e9fc
Merge branch 'master' into DG-update
pbthang Nov 7, 2021
85fe174
Merge branch 'master' of https://github.com/AY2122S1-CS2103T-T17-1/tp
hernpiblo Nov 7, 2021
3ab21f0
Merge pull request #242 from clementkfj/branch-DG-Appendix
pbthang Nov 7, 2021
53fcebb
Merge branch 'master' of https://github.com/pbthang/tp into DG-update
pbthang Nov 7, 2021
784a9ae
Merge pull request #241 from pbthang/DG-update
pbthang Nov 7, 2021
84bb108
Merge branch 'master' of https://github.com/pbthang/tp into DG-update
pbthang Nov 7, 2021
3cd2ca4
add use case for add and edit reservation
pbthang Nov 7, 2021
de7cd66
Merge branch 'master' of https://github.com/AY2122S1-CS2103T-T17-1/tp
hernpiblo Nov 7, 2021
e5717c9
update pbthang PPP
pbthang Nov 7, 2021
8457963
Merge pull request #247 from pbthang/DG-update
Javiier-pzk Nov 7, 2021
560d208
Merge branch 'master' of https://github.com/AY2122S1-CS2103T-T17-1/tp
hernpiblo Nov 7, 2021
17fc9a4
Standardise and improve existing use cases
Javiier-pzk Nov 7, 2021
044aa22
Add Delete and Sort Use cases
Javiier-pzk Nov 7, 2021
3a8ec3b
Update dg to include new use cases, test cases and glossary
hernpiblo Nov 7, 2021
c3d062e
Update ppp
hernpiblo Nov 7, 2021
d2ca172
Replace status bar with result display in DG
hernpiblo Nov 7, 2021
54d748e
Add Manual Test cases in DG
Javiier-pzk Nov 7, 2021
a7540f2
Edit DG
Javiier-pzk Nov 7, 2021
5fffe84
Add new line to EOF
Javiier-pzk Nov 7, 2021
041e30b
Change RHRH file path
Javiier-pzk Nov 7, 2021
55dfb11
Merge pull request #251 from Javiier-pzk/branch-DG-UseCases-manualTes…
pbthang Nov 7, 2021
b367f6a
Merge branch 'master' of https://github.com/AY2122S1-CS2103T-T17-1/tp…
hernpiblo Nov 8, 2021
8565b9a
Merge pull request #250 from hernpiblo/v1.4b-dg-usecase-testcase
pbthang Nov 8, 2021
6a75c5b
Update clementkfj.md
clementkfj Nov 8, 2021
31717a7
Updated Find usecases and Find, Edit manual testing
chetwinlow Nov 8, 2021
041bedb
Updated list and reset command manual testing
chetwinlow Nov 8, 2021
090e48a
Updated list and reset command use case
chetwinlow Nov 8, 2021
008b745
Updated list and reset command use case
chetwinlow Nov 8, 2021
33520f1
Merge pull request #254 from chetwinlow/branch-update-DG-find-edit-ma…
hernpiblo Nov 8, 2021
0ef01fb
Update hernpiblo.md
hernpiblo Nov 8, 2021
3e1fd0c
fix use cases and add new use cases
pbthang Nov 8, 2021
2d35902
format things in DG
pbthang Nov 8, 2021
527ff03
update DG use case index
pbthang Nov 8, 2021
7fa472f
Merge pull request #255 from pbthang/DG-update
Javiier-pzk Nov 8, 2021
a2d1993
fix things
pbthang Nov 8, 2021
38e7e76
fix gthings
pbthang Nov 8, 2021
fe574c4
fix typo
pbthang Nov 8, 2021
c1ef659
Merge pull request #256 from pbthang/DG-update
Javiier-pzk Nov 8, 2021
4586779
Final cosmetic changes to DG and update javiier-pzk PPP
Javiier-pzk Nov 8, 2021
774578e
Edit numbering
Javiier-pzk Nov 8, 2021
80c29fd
Merge pull request #257 from Javiier-pzk/branch-DG-UseCases-manualTes…
pbthang Nov 8, 2021
b865674
Update DeveloperGuide.md
Javiier-pzk Nov 8, 2021
b8d61dc
change fontsize for UI Class diagram
pbthang Nov 8, 2021
c671a4f
fix size of UI class diagram
pbthang Nov 8, 2021
627a53d
Merge pull request #258 from pbthang/DG-update
Javiier-pzk Nov 8, 2021
f85a3dd
Update DeveloperGuide.md
Javiier-pzk Nov 8, 2021
a4bf235
Update javiier-pzk.md
Javiier-pzk Nov 8, 2021
5ff3bce
Update UserGuide.md
hernpiblo Nov 8, 2021
456a1ef
Update UserGuide.md
hernpiblo Nov 8, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 15 additions & 15 deletions docs/DeveloperGuide.md
Original file line number Diff line number Diff line change
@@ -118,7 +118,7 @@ How the parsing works:

The `Model` component,

* stores the address book data i.e., all `Customer`, `Employee`, `Supplier` and `Reservation` objects (which are contained in a `UniqueCustomerList`, `UniqueEmployeeList`, `UniqueSupplierList` and `UniqueReservationList` object respectively).
* stores RHRH data i.e., all `Customer`, `Employee`, `Supplier` and `Reservation` objects (which are contained in a `UniqueCustomerList`, `UniqueEmployeeList`, `UniqueSupplierList` and `UniqueReservationList` object respectively).
* stores the currently 'selected' `Customer`/`Employee`/`Supplier`/`Reservation` objects (e.g., results of a search query) as a separate _filtered_ list which is exposed to outsiders as an unmodifiable `ObservableList<Customer>`/`ObservableList<Employee>`/`ObservableList<Supplier>`/`ObservableList<Reservation>` respectively that can be 'observed' e.g. the UI can be bound to this list so that the UI automatically updates when the data in the list change.
* stores a `UserPref` object that represents the user’s preferences. This is exposed to the outside as a `ReadOnlyUserPref` objects.
* does not depend on any of the other three components (as the `Model` represents data entities of the domain, they should make sense on their own without depending on other components)
@@ -137,7 +137,7 @@ The `Model` component,
<img src="images/StorageClassDiagram.png" width="550" />

The `Storage` component,
* can save both address book data and user preference data in json format, and read them back into corresponding objects.
* can save both RHRH data and user preference data in json format, and read them back into corresponding objects.
* inherits from both `RhrhStorage` and `UserPrefStorage`, which means it can be treated as either one (if only the functionality of only one is needed).
* depends on some classes in the `Model` component (because the `Storage` component's job is to save/retrieve objects that belong to the `Model`)

@@ -516,31 +516,31 @@ display the reservations along with customer information.

The proposed undo/redo mechanism is facilitated by `VersionedRhrh`. It extends `Rhrh` with an undo/redo history, stored internally as an `rhrhStateList` and `currentStatePointer`. Additionally, it implements the following operations:

* `VersionedRhrh#commit()` — Saves the current address book state in its history.
* `VersionedRhrh#undo()` — Restores the previous address book state from its history.
* `VersionedRhrh#redo()` — Restores a previously undone address book state from its history.
* `VersionedRhrh#commit()` — Saves the current RHRH state in its history.
* `VersionedRhrh#undo()` — Restores the previous RHRH state from its history.
* `VersionedRhrh#redo()` — Restores a previously undone RHRH state from its history.

These operations are exposed in the `Model` interface as `Model#commitRhrh()`, `Model#undoRhrh()` and `Model#redoRhrh()` respectively.

Given below is an example usage scenario and how the undo/redo mechanism behaves at each step.

Step 1. The user launches the application for the first time. The `VersionedRhrh` will be initialized with the initial address book state, and the `currentStatePointer` pointing to that single address book state.
Step 1. The user launches the application for the first time. The `VersionedRhrh` will be initialized with the initial RHRH state, and the `currentStatePointer` pointing to that single RHRH state.

![UndoRedoState0](images/UndoRedoState0.png)

Step 2. The user executes `delete 5` command to delete the 5th person in the address book. The `delete` command calls `Model#commitRhrh()`, causing the modified state of the address book after the `delete 5` command executes to be saved in the `rhrhStateList`, and the `currentStatePointer` is shifted to the newly inserted address book state.
Step 2. The user executes `delete 5` command to delete the 5th person in RHRH. The `delete` command calls `Model#commitRhrh()`, causing the modified state of RHRH after the `delete 5` command executes to be saved in the `rhrhStateList`, and the `currentStatePointer` is shifted to the newly inserted RHRH state.

![UndoRedoState1](images/UndoRedoState1.png)

Step 3. The user executes `add n/David …​` to add a new person. The `add` command also calls `Model#commitRhrh()`, causing another modified address book state to be saved into the `rhrhStateList`.
Step 3. The user executes `add n/David …​` to add a new person. The `add` command also calls `Model#commitRhrh()`, causing another modified RHRH state to be saved into the `rhrhStateList`.

![UndoRedoState2](images/UndoRedoState2.png)

<div markdown="span" class="alert alert-info">:information_source: **Note:** If a command fails its execution, it will not call `Model#commitRhrh()`, so the address book state will not be saved into the `rhrhStateList`.
<div markdown="span" class="alert alert-info">:information_source: **Note:** If a command fails its execution, it will not call `Model#commitRhrh()`, so RHRH state will not be saved into the `rhrhStateList`.

</div>

Step 4. The user now decides that adding the person was a mistake, and decides to undo that action by executing the `undo` command. The `undo` command will call `Model#undoRhrh()`, which will shift the `currentStatePointer` once to the left, pointing it to the previous address book state, and restores the address book to that state.
Step 4. The user now decides that adding the person was a mistake, and decides to undo that action by executing the `undo` command. The `undo` command will call `Model#undoRhrh()`, which will shift the `currentStatePointer` once to the left, pointing it to the previous RHRH state, and restores RHRH to that state.

![UndoRedoState3](images/UndoRedoState3.png)

@@ -557,17 +557,17 @@ The following sequence diagram shows how the undo operation works:

</div>

The `redo` command does the opposite — it calls `Model#redoRhrh()`, which shifts the `currentStatePointer` once to the right, pointing to the previously undone state, and restores the address book to that state.
The `redo` command does the opposite — it calls `Model#redoRhrh()`, which shifts the `currentStatePointer` once to the right, pointing to the previously undone state, and restores RHRH to that state.

<div markdown="span" class="alert alert-info">:information_source: **Note:** If the `currentStatePointer` is at index `rhrhStateList.size() - 1`, pointing to the latest address book state, then there are no undone Rhrh states to restore. The `redo` command uses `Model#canRedoRhrh()` to check if this is the case. If so, it will return an error to the user rather than attempting to perform the redo.
<div markdown="span" class="alert alert-info">:information_source: **Note:** If the `currentStatePointer` is at index `rhrhStateList.size() - 1`, pointing to the latest RHRH state, then there are no undone Rhrh states to restore. The `redo` command uses `Model#canRedoRhrh()` to check if this is the case. If so, it will return an error to the user rather than attempting to perform the redo.

</div>

Step 5. The user then decides to execute the command `list`. Commands that do not modify the address book, such as `list`, will usually not call `Model#commitRhrh()`, `Model#undoRhrh()` or `Model#redoRhrh()`. Thus, the `rhrhStateList` remains unchanged.
Step 5. The user then decides to execute the command `list`. Commands that do not modify RHRH, such as `list`, will usually not call `Model#commitRhrh()`, `Model#undoRhrh()` or `Model#redoRhrh()`. Thus, the `rhrhStateList` remains unchanged.

![UndoRedoState4](images/UndoRedoState4.png)

Step 6. The user executes `clear`, which calls `Model#commitRhrh()`. Since the `currentStatePointer` is not pointing at the end of the `rhrhStateList`, all address book states after the `currentStatePointer` will be purged. Reason: It no longer makes sense to redo the `add n/David …​` command. This is the behavior that most modern desktop applications follow.
Step 6. The user executes `clear`, which calls `Model#commitRhrh()`. Since the `currentStatePointer` is not pointing at the end of the `rhrhStateList`, all RHRH states after the `currentStatePointer` will be purged. Reason: It no longer makes sense to redo the `add n/David …​` command. This is the behavior that most modern desktop applications follow.

![UndoRedoState5](images/UndoRedoState5.png)

@@ -579,7 +579,7 @@ The following activity diagram summarizes what happens when a user executes a ne

**Aspect: How undo & redo executes:**

* **Alternative 1 (current choice):** Saves the entire address book.
* **Alternative 1 (current choice):** Saves the entire RHRH.
* Pros: Easy to implement.
* Cons: May have performance issues in terms of memory usage.

1 change: 0 additions & 1 deletion docs/UserGuide.md
Original file line number Diff line number Diff line change
@@ -66,7 +66,6 @@ Dangerous or potentially negative actions are displayed here
- Format: `addC n/NAME p/PHONE_NUMBER e/EMAIL a/ADDRESS lp/LOYALTYPOINTS [alg/ALLERGIES] [sr/SPECIAL_REQUESTS] [t/TAG]...`
- Example: `addC n/John Doe p/87654321 e/e12345@u.nus.edu a/Clementi lp/1000`


6. Refer to the [Features](#features) below for details of each command. If you want to have an overview of all the commands, you can refer to [Command Summary](#command-summary) section.

### Command syntax
2 changes: 1 addition & 1 deletion docs/diagrams/AddEmployeeCommandSequenceDiagram.puml
Original file line number Diff line number Diff line change
@@ -28,7 +28,7 @@ activate addEmployeeCommandParser
addEmployeeCommandParser --[LOGIC_COLOR]> rhrhParser
deactivate addEmployeeCommandParser

rhrhParser -[LOGIC_COLOR]> addEmployeeCommandParser :"parse(n/John Doe...)"
rhrhParser -[LOGIC_COLOR]> addEmployeeCommandParser :parse(n/John Doe...)
activate addEmployeeCommandParser

create command
Binary file modified docs/images/AddEmployeeCommandSequenceDiagram.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion docs/team/chetwinlow.md
Original file line number Diff line number Diff line change
@@ -43,7 +43,7 @@ restaurants.
* Implemented logic for earlier iterations of [`Find`](https://github.com/AY2122S1-CS2103T-T17-1/tp/pull/98) command.

#### Review and Mentoring contributions
* PRs reviewed with comments(non-exhaustive): PRs [\#191](https://github.com/AY2122S1-CS2103T-T17-1/tp/pull/191),
* PRs reviewed with comments(non-exhaustive): PRs [\#227](https://github.com/AY2122S1-CS2103T-T17-1/tp/pull/227), [\#191](https://github.com/AY2122S1-CS2103T-T17-1/tp/pull/191),
[\#99](https://github.com/AY2122S1-CS2103T-T17-1/tp/pull/99), [\#92](https://github.com/AY2122S1-CS2103T-T17-1/tp/pull/92)

#### Contributions beyond the team project
2 changes: 1 addition & 1 deletion docs/team/clementkfj.md
Original file line number Diff line number Diff line change
@@ -44,7 +44,7 @@ Given below are my contributions to the project.
* Improve `Find` Employees command to search more accurately for `Shift` (Pull request [\#131](https://github.com/AY2122S1-CS2103T-T17-1/tp/pull/131))
* Improve `Find` Suppliers and Customers command to search more accurately (Pull request [\#131](https://github.com/AY2122S1-CS2103T-T17-1/tp/pull/131))
* Fix PE-D related bugs, changing validity checkers to enforce stricter rules for entering fields so people will not find bugs in it (Issues [\#154](https://github.com/AY2122S1-CS2103T-T17-1/tp/issues/154), [\#155](https://github.com/AY2122S1-CS2103T-T17-1/tp/issues/155) and [\#162](https://github.com/AY2122S1-CS2103T-T17-1/tp/issues/162), Pull request [\#177](https://github.com/AY2122S1-CS2103T-T17-1/tp/pull/177))
* Removed all instances of Address Book in RHRH (Pull requests [\#201](https://github.com/AY2122S1-CS2103T-T17-1/tp/pull/201))
* Removed all instances of address book in RHRH (Pull requests [\#201](https://github.com/AY2122S1-CS2103T-T17-1/tp/pull/201))

* **Documentation**:
* User Guide:
2 changes: 1 addition & 1 deletion docs/team/johndoe.md
Original file line number Diff line number Diff line change
@@ -5,7 +5,7 @@ title: John Doe's Project Portfolio Page

### Project: Rhrh Level 3

Rhrh - Level 3 is a desktop address book application used for teaching Software Engineering principles. The user interacts with it using a CLI, and it has a GUI created with JavaFX. It is written in Java, and has about 10 kLoC.
Rhrh - Level 3 is a desktop RHRH application used for teaching Software Engineering principles. The user interacts with it using a CLI, and it has a GUI created with JavaFX. It is written in Java, and has about 10 kLoC.

Given below are my contributions to the project.

6 changes: 3 additions & 3 deletions docs/tutorials/AddRemark.md
Original file line number Diff line number Diff line change
@@ -5,7 +5,7 @@ title: "Tutorial: Adding a command"

Let's walk you through the implementation of a new command — `remark`.

This command allows users of the Rhrh application to add optional remarks to people in their address book and edit it if required. The command should have the following format:
This command allows users of the Rhrh application to add optional remarks to people in their RHRH and edit it if required. The command should have the following format:

`remark INDEX r/REMARK` (e.g., `remark 2 r/Likes baseball`)

@@ -28,7 +28,7 @@ package seedu.address.logic.commands;
import seedu.address.model.Model;

/**
* Changes the remark of an existing person in the address book.
* Changes the remark of an existing person in RHRH.
*/
public class RemarkCommand extends Command {

@@ -295,7 +295,7 @@ While the changes to code may be minimal, the test data will have to be updated

<div markdown="span" class="alert alert-warning">

:exclamation: You must delete Rhrh’s storage file located at `/data/addressbook.json` before running it! Not doing so will cause Rhrh to default to an empty address book!
:exclamation: You must delete Rhrh’s storage file located at `/data/addressbook.json` before running it! Not doing so will cause Rhrh to default to an empty RHRH!

</div>

4 changes: 2 additions & 2 deletions docs/tutorials/TracingCode.md
Original file line number Diff line number Diff line change
@@ -292,10 +292,10 @@ Here are some quick questions you can try to answer based on your execution path

2. Allow `delete` to remove more than one index at a time

3. Save the address book in the CSV format instead
3. Save RHRH in the CSV format instead

4. Add a new command

5. Add a new field to `Person`

6. Add a new entity to the address book
6. Add a new entity to RHRH
8 changes: 4 additions & 4 deletions src/main/java/seedu/address/MainApp.java
Original file line number Diff line number Diff line change
@@ -69,9 +69,9 @@ public void init() throws Exception {
}

/**
* Returns a {@code ModelManager} with the data from {@code storage}'s address book and {@code userPrefs}. <br>
* The data from the sample address book will be used instead if {@code storage}'s address book is not found,
* or an empty address book will be used instead if errors occur when reading {@code storage}'s address book.
* Returns a {@code ModelManager} with the data from {@code storage}'s RHRH and {@code userPrefs}. <br>
* The data from the sample RHRH will be used instead if {@code storage}'s RHRH is not found,
* or an empty RHRH will be used instead if errors occur when reading {@code storage}'s RHRH.
*/
private Model initModelManager(Storage storage, ReadOnlyUserPrefs userPrefs) {
Optional<ReadOnlyRhrh> rhrhOptional;
@@ -173,7 +173,7 @@ public void start(Stage primaryStage) {

@Override
public void stop() {
logger.info("============================ [ Stopping Address Book ] =============================");
logger.info("============================ [ Stopping RHRH ] =============================");
try {
storage.saveUserPrefs(model.getUserPrefs());
} catch (IOException e) {
2 changes: 1 addition & 1 deletion src/main/java/seedu/address/logic/Logic.java
Original file line number Diff line number Diff line change
@@ -45,7 +45,7 @@ public interface Logic {
ObservableList<Reservation> getFilteredReservations();

/**
* Returns the user prefs' address book file path.
* Returns the user prefs' RHRH file path.
*/
Path getRhrhFilePath();

Original file line number Diff line number Diff line change
@@ -20,7 +20,7 @@ public class AddCustomerCommand extends Command {
public static final String COMMAND_WORD = "addc";

public static final String MESSAGE_USAGE = CommandUtil.formatCommandWord(COMMAND_WORD)
+ ": Adds a customer to the address book. "
+ ": Adds a customer to RHRH. "
+ "Parameters: "
+ PREFIX_NAME + "NAME "
+ PREFIX_PHONE + "PHONE "
Original file line number Diff line number Diff line change
@@ -17,13 +17,13 @@
import seedu.address.model.person.employee.Employee;

/**
* Adds an employee to the address book.
* Adds an employee to RHRH.
*/
public class AddEmployeeCommand extends Command {
public static final String COMMAND_WORD = "adde";

public static final String MESSAGE_USAGE = CommandUtil.formatCommandWord(COMMAND_WORD)
+ ": Adds an employee to the address book. "
+ ": Adds an employee to RHRH. "
+ "Parameters: "
+ PREFIX_NAME + "NAME "
+ PREFIX_PHONE + "PHONE "
@@ -46,7 +46,7 @@ public class AddEmployeeCommand extends Command {
+ PREFIX_TAG + "Team C";

public static final String MESSAGE_SUCCESS = "New employee has been added: %1$s";
public static final String MESSAGE_DUPLICATE_EMPLOYEE = "Employee information already exists in the address book";
public static final String MESSAGE_DUPLICATE_EMPLOYEE = "Employee information already exists in RHRH";

private final Employee toAdd;

Original file line number Diff line number Diff line change
@@ -15,13 +15,13 @@
import seedu.address.model.person.supplier.Supplier;

/**
* Adds a supplier to the address book.
* Adds a supplier to RHRH.
*/
public class AddSupplierCommand extends Command {
public static final String COMMAND_WORD = "adds";

public static final String MESSAGE_USAGE = CommandUtil.formatCommandWord(COMMAND_WORD)
+ ": Adds a person to the address book. "
+ ": Adds a person to RHRH. "
+ "Parameters: "
+ PREFIX_NAME + "NAME "
+ PREFIX_PHONE + "PHONE "
@@ -41,7 +41,7 @@ public class AddSupplierCommand extends Command {
+ PREFIX_DELIVERY_DETAILS + "12:00 10-11-2021";

public static final String MESSAGE_SUCCESS = "New supplier added: %1$s";
public static final String MESSAGE_DUPLICATE_SUPPLIER = "This supplier already exists in the address book";
public static final String MESSAGE_DUPLICATE_SUPPLIER = "This supplier already exists in RHRH";

private final Supplier toAdd;

Original file line number Diff line number Diff line change
@@ -6,7 +6,7 @@
import seedu.address.model.Rhrh;

/**
* Clears the address book.
* Clears RHRH.
*/
public class ClearCommand extends Command {

Original file line number Diff line number Diff line change
@@ -12,7 +12,7 @@
import seedu.address.model.person.customer.Customer;

/**
* Deletes a customer identified using it's displayed index from the address book.
* Deletes a customer identified using it's displayed index from RHRH.
*/
public class DeleteCustomerCommand extends Command {

Original file line number Diff line number Diff line change
@@ -12,7 +12,7 @@
import seedu.address.model.person.employee.Employee;

/**
* Deletes an employee identified using it's displayed index from the address book.
* Deletes an employee identified using it's displayed index from RHRH.
*/
public class DeleteEmployeeCommand extends Command {

Original file line number Diff line number Diff line change
@@ -12,7 +12,7 @@
import seedu.address.model.reservation.Reservation;

/**
* Deletes a reservation identified using it's displayed index from the address book.
* Deletes a reservation identified using it's displayed index from RHRH.
*/
public class DeleteReservationCommand extends Command {

Original file line number Diff line number Diff line change
@@ -12,7 +12,7 @@
import seedu.address.model.person.supplier.Supplier;

/**
* Deletes a supplier identified using it's displayed index from the address book.
* Deletes a supplier identified using it's displayed index from RHRH.
*/
public class DeleteSupplierCommand extends Command {

Original file line number Diff line number Diff line change
@@ -35,7 +35,7 @@


/**
* Edits the details of an existing customer in the address book.
* Edits the details of an existing customer in RHRH.
*/
public class EditCustomerCommand extends Command {
public static final String COMMAND_WORD = "editc";
@@ -67,6 +67,8 @@ public class EditCustomerCommand extends Command {
private final EditCustomerDescriptor editCustomerDescriptor;

/**
* Constructs an EditCustomerCommand to edit the customer at {@code Index}
*
* @param index of the customer in the filtered customer list to edit
* @param editCustomerDescriptor details to edit the customer with
*/
Loading