[Moo Jun Wei] iP #504
Open
[Moo Jun Wei] iP #504
+2,478
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvinjiang1
reviewed
Aug 31, 2022
src/main/java/tasks/Deadline.java
Outdated
| @Override | ||
| public String toDataString() { | ||
| return String.format("[D] | %d | %s | %s", | ||
| isMarked() ? 1 : 0, |
There was a problem hiding this comment.
Perhaps you could look into replacing the 1 and 0 in the conditional statement with a named constant? It could be considered a "magic number".
src/main/java/Duke.java
Outdated
Comment on lines
41
to
44
| System.out.println( | ||
| "Hello! I'm Duke\n" + | ||
| "What can I do for you?" | ||
| ); |
There was a problem hiding this comment.
Could perhaps break up the line before the operator, in accordance with the coding standards?
src/main/java/Duke.java
Outdated
| loop(sc); | ||
| } | ||
|
|
||
| public void loop(Scanner sc) { |
There was a problem hiding this comment.
This method looks long and complex, could think of abstracting out key components into different methods?
src/main/java/Duke.java
Outdated
| import java.io.IOException; | ||
| import java.util.List; | ||
| import java.util.Scanner; | ||
|
|
||
| public class Duke { |
There was a problem hiding this comment.
It would be great if javadocs are included :))
Previously, the parse() method is lengthy. The body is divided into two main responsibilities - separating the input into the command keyword and the body, and then parsing them to return a Command. Code blocks are extracted into two private methods to improve the readability of the code and adhere to a single level\ of abstraction within parse().
Improve code quality in InputParser
Performing consecutive undos will undo commands one-by-one in order of the history of executed commands. Undo itself is not included in the history of executed commands.
Add ability to undo commands
Lan-Jingbo
reviewed
Sep 15, 2022
Comment on lines
26
to
43
| switch (command) { | ||
| case "bye": | ||
| return new ExitCommand(ui); | ||
| case "list": | ||
| return new PrintTasksCommand(ui, tasks); | ||
| case "mark": | ||
| return new MarkTaskCommand(storage, ui, tasks, body); | ||
| case "unmark": | ||
| return new UnmarkTaskCommand(storage, ui, tasks, body); | ||
| case "delete": | ||
| return new DeleteTaskCommand(storage, ui, tasks, body); | ||
| case "find": | ||
| return new FindTaskCommand(tasks, ui, body); | ||
| case "todo": | ||
| return new AddTaskCommand(storage, ui, tasks, TaskType.TODO, body); | ||
| case "deadline": | ||
| return new AddTaskCommand(storage, ui, tasks, TaskType.DEADLINE, body); | ||
| case "event": |
There was a problem hiding this comment.
I think this change(from if to swtich) is good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Duke
Features
Downloads
Duke is FREE to download and use! (releases)
Quick Start
todo buy grocerieslistmark 1Implementation
Here's the main method:
To be Completed