[Sien Soon] iP #505
Open
[Sien Soon] iP #505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Edited EXPECTED.TXT for TextUiTesting
BlopApple
reviewed
Sep 1, 2022
src/main/java/Deadline.java
Outdated
|
|
||
| public class Deadline extends Task { | ||
|
|
||
| protected LocalDateTime by; |
There was a problem hiding this comment.
Maybe you could name it as "deadlineTime" instead of "by"?
src/main/java/Duke.java
Outdated
Comment on lines
21
to
23
| duke.greeting(); | ||
| duke.run(); | ||
| duke.goodBye(); |
There was a problem hiding this comment.
Maybe you could name the methods as verbs like greet() and exit() instead?
src/main/java/Duke.java
Outdated
Comment on lines
44
to
67
| case "T": { | ||
| Task task = new ToDo(taskInArray[2]); | ||
| taskList.add(task); | ||
| if (taskInArray[1].equals("1")) { | ||
| task.markAsDone(); | ||
| } | ||
| break; | ||
| } | ||
|
|
||
| case "D": { | ||
| Task task = new Deadline(taskInArray[2], taskInArray[3]); | ||
| taskList.add(task); | ||
| if (taskInArray[1].equals("1")) { | ||
| task.markAsDone(); | ||
| } | ||
| break; | ||
| } | ||
|
|
||
| case "E": { | ||
| Task task = new Event(taskInArray[2], taskInArray[3]); | ||
| taskList.add(task); | ||
| if (taskInArray[1].equals("1")) { | ||
| task.markAsDone(); | ||
| } |
There was a problem hiding this comment.
Since in each case you are marking the task as done when loading them, maybe u can abstract the process out?
TYKCodes
reviewed
Sep 4, 2022
src/main/java/Duke.java
Outdated
| public class Duke { | ||
|
|
||
| private final String horizontalLine = "-------------------------"; |
There was a problem hiding this comment.
You may want the name of your constant variables like this one to match the coding standard. Perhaps something like:
Suggested change
| private final String horizontalLine = "-------------------------"; | |
| private final String HORIZONTAL_LINE = "-------------------------"; |
src/main/java/Duke.java
Outdated
Comment on lines
43
to
69
| switch (taskType) { | ||
| case "T": { | ||
| Task task = new ToDo(taskInArray[2]); | ||
| taskList.add(task); | ||
| if (taskInArray[1].equals("1")) { | ||
| task.markAsDone(); | ||
| } | ||
| break; | ||
| } | ||
|
|
||
| case "D": { | ||
| Task task = new Deadline(taskInArray[2], taskInArray[3]); | ||
| taskList.add(task); | ||
| if (taskInArray[1].equals("1")) { | ||
| task.markAsDone(); | ||
| } | ||
| break; | ||
| } | ||
|
|
||
| case "E": { | ||
| Task task = new Event(taskInArray[2], taskInArray[3]); | ||
| taskList.add(task); | ||
| if (taskInArray[1].equals("1")) { | ||
| task.markAsDone(); | ||
| } | ||
| break; | ||
| } |
There was a problem hiding this comment.
The indentation for each case statement should be aligned to the switch
# Conflicts: # src/main/java/duke/TaskList.java
To allow Duke to understand dates and times instead of string for event schedule. Store dates and times in format (yyyy-mm-ddThh:mm:ss) and prints in a different format (MMM dd yyyy hh:mm:ss).
Exits Duke when "bye" is entered by user
…mark, unmark, delete and find is performed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DukePro
DukePro frees your mind of having to remember things you need to do. It's,
FASTSUPER FAST to useAll you need to do is,
And it is FREE!
Features: