Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add EOF line #404

Closed
wants to merge 821 commits into from
Closed

Add EOF line #404

wants to merge 821 commits into from

Conversation

tohjh
Copy link

@tohjh tohjh commented Nov 12, 2024

No description provided.

Incogdino and others added 30 commits November 7, 2024 16:41
@Incogdino
Update readme
84fb984 
Standardize name for application.
@Incogdino
Merge branch 'master' into branch-updateReadMe
e9f3af0
@Incogdino
Update screenshot for view command
647d287
@Incogdino
Merge pull request AY2425S1-CS2103T-T11-2#259 from Incogdino/branch-u…
ad957cd 
…pdateScreenshot

Update screenshots of user guide
@Incogdino
Merge branch 'master' into branch-updateReadMe
cfeec99
@Incogdino
Merge pull request AY2425S1-CS2103T-T11-2#262 from Incogdino/branch-u…
820b7dc 
…pdateReadMe

Update Readme
@Incogdino
Merge branch 'master' into branch-editDeveloperGuide
12c472c
@SwaminathanViswa
Merge pull request AY2425S1-CS2103T-T11-2#263 from SwaminathanViswa/b…
80ff6dc 
…ranch-editDeveloperGuide

Add acknowledgements to developer guide
@currynia
Fix view bug
4ab70f5
@currynia
Fix checkstyle
165fd1c
@currynia
Merge branch 'master'
b5941a6
@Incogdino
Update ReadMe
b5e219b
@Incogdino
Update Readme
8f1f7fa
@tohjh
Fix style and isolate test cases
e000afb
@Incogdino
Update user guide
6b321c8 
Previously, Github command shortcut is specified with a caps.
@tohjh
Fix style
939b5fc
@tohjh
Fix file
5746c19
@currynia
Update ug and dg
4b76c11
@currynia
Fix typo
44a3236
@currynia
Merge pull request AY2425S1-CS2103T-T11-2#268
fa8395a 
Update user guide
@currynia
Merge branch 'master' into branch-ug
d4b9221
@currynia
Merge branch 'master' into branch-updateReadMe
fca023b
@currynia
Merge pull request AY2425S1-CS2103T-T11-2#266
7b6be3a 
Update ReadMe
@Incogdino
Merge branch 'master' into branch-ug
5e8452e
@Incogdino
Merge branch 'master' into branch-view
1a3d65b
@Incogdino
Merge pull request AY2425S1-CS2103T-T11-2#269 from currynia/branch-ug
c78aa22 
Minor update to ug and dg
@Incogdino
Merge branch 'master' into branch-view
6aa8341
@Incogdino
Merge pull request AY2425S1-CS2103T-T11-2#265 from currynia/branch-view
dee7467 
Fix bug for view command
@SwaminathanViswa
Add page breaks to user and developer guide
2cfd5dc
@DesSnowy
Improve error message for sort
24b5b69
SwaminathanViswa and others added 28 commits November 12, 2024 13:26
@SwaminathanViswa
Update activity diagram for mark command
4e673df
@currynia
Update explanation
9d08038
@currynia
Merge branch 'master'
b493cc2
@currynia
Fix checkstyle
1713f78
@SwaminathanViswa
Merge branch 'branch-updateComments' of https://github.com/Swaminatha…
a273552 
…nViswa/tp into branch-updateComments

# Conflicts:
#	docs/DeveloperGuide.md
@currynia
Merge pull request AY2425S1-CS2103T-T11-2#380
d19d4f4 
Update DG
@currynia
Merge branch 'master'
0aa678f
@Incogdino
Update dg
12a30c4 
- Updated puml for command history.
- Add details on command history use.
@currynia
Fix style
a1fb662
@Incogdino
Merge branch 'branch-formatDg' of https://github.com/Incogdino/tp int…
3d39661 
…o branch-formatDg
@Incogdino
Merge branch 'master' into branch-updateComments
aa27781
@DesSnowy
Fix images
6c9fc6a
@currynia
Merge pull request AY2425S1-CS2103T-T11-2#382
f48695d 
Add UML diagram for mark command
@Incogdino
Merge branch 'master' into branch-formatDg
f1e6853
@SwaminathanViswa
Merge branch 'master' into branch-dg
9b10af2
@Incogdino
Merge branch 'master' into branch-addImplementation
408c524
@Incogdino
Merge pull request AY2425S1-CS2103T-T11-2#384 from DesSnowy/branch-ad…
2cdee0c 
…dImplementation

Fix add implementataion diagram
@tohjh
Update DG for Export Command
77eaa80
@Incogdino
Merge branch 'master' into branch-dg
260cb95
@Incogdino
Merge branch 'master' into branch-formatDg
3b8e6bb
@Incogdino
Merge pull request AY2425S1-CS2103T-T11-2#383 from Incogdino/branch-f…
0f179cc 
…ormatDg

Branch format dg
@Incogdino
Merge branch 'master' into branch-dg
d2e6394
@Incogdino
Merge branch 'master' into branch-add-diagram
48827f2
@SwaminathanViswa
Merge pull request AY2425S1-CS2103T-T11-2#381 from currynia/branch-dg
b2e666b 
Implementation for addgrade
@tohjh
Add new line at EOF
72c4427
@Incogdino
Merge branch 'master' into branch-add-diagram
efd3e59
@currynia
Merge pull request AY2425S1-CS2103T-T11-2#385
ea6916a 
Update DG for Export Command
@tohjh
Merge branch 'master' of https://github.com/AY2425S1-CS2103T-T11-2/tp …
ecd2e14 
…into branch-add-diagram
@tohjh tohjh closed this Nov 12, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

Attention: Patch coverage is 76.82927% with 19 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/main/java/seedu/address/ui/MainWindow.java 0.00% 7 Missing ⚠️
...java/seedu/address/logic/commands/ViewCommand.java 63.63% 4 Missing ⚠️
.../seedu/address/commons/core/FunctionalBrowser.java 25.00% 3 Missing ⚠️
src/main/java/seedu/address/MainApp.java 0.00% 2 Missing ⚠️
...va/seedu/address/logic/commands/ImportCommand.java 83.33% 1 Missing ⚠️
...eedu/address/logic/parser/CsvAssignmentParser.java 66.66% 0 Missing and 1 partial ⚠️
.../java/seedu/address/logic/parser/CsvRowParser.java 0.00% 0 Missing and 1 partial ⚠️
Files with missing lines Coverage Δ Complexity Δ
...in/java/seedu/address/commons/core/LogsCenter.java 78.78% <ø> (ø) 5.00 <0.00> (ø)
.../java/seedu/address/logic/commands/AddCommand.java 100.00% <100.00%> (ø) 8.00 <1.00> (ø)
.../seedu/address/logic/commands/AddGradeCommand.java 79.59% <100.00%> (ø) 12.00 <0.00> (?)
...ava/seedu/address/logic/commands/ClearCommand.java 100.00% <ø> (ø) 2.00 <0.00> (ø)
...va/seedu/address/logic/commands/DeleteCommand.java 91.30% <100.00%> (-8.70%) 8.00 <1.00> (+1.00) ⬇️
...java/seedu/address/logic/commands/EditCommand.java 95.55% <100.00%> (-1.89%) 13.00 <0.00> (ø)
...java/seedu/address/logic/commands/ExitCommand.java 100.00% <ø> (ø) 2.00 <0.00> (ø)
...va/seedu/address/logic/commands/ExportCommand.java 85.71% <100.00%> (ø) 10.00 <1.00> (?)
...va/seedu/address/logic/commands/FilterCommand.java 100.00% <100.00%> (ø) 7.00 <1.00> (?)
...java/seedu/address/logic/commands/FindCommand.java 87.50% <ø> (-12.50%) 5.00 <0.00> (-1.00)
... and 35 more

... and 3 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tohjh @Incogdino @SwaminathanViswa @currynia @DesSnowy