Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shell-alike UI/UX #43

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Shell-alike UI/UX #43

wants to merge 1 commit into from

Conversation

knoopx
Copy link
Contributor

@knoopx knoopx commented Jun 23, 2022

this is a rebase of my previous work on #32. just opening for discussion/future consideration.

@fdncred
Copy link
Collaborator

fdncred commented Jun 23, 2022

@knoopx After a quick read through, this is a summary of some (hopefully most) of the changes I see. Any 1 these could be 1 PR but having them all together makes it difficult to digest. Here's the list and (only) my opinion on the items.

  1. changes theme to "knoopx dark" vs solarized - let's keep solarized for now
  2. adds cool completion dialog - love it, let's keep it
  3. changes cwd to small form - keep it themed the old way
  4. changes they way keyboard events are captured - like it
  5. changes input prompt - like it but keep the old theme
  6. changes table/record/list rendering - like it but keep the old theme
  7. adds duration display string - like it but make it match the old theme
  8. changes the result handler - not sure
  9. adds a spinner - thing it's a good idea - keep it
  10. removes most of main.css styles - may be related to 1 - probably needs reverting to keep the old theme?
  11. has conflicts - just needs a rebase

@rgwood @jntrnr thoughts?

@rgwood
Copy link
Contributor

rgwood commented Jun 23, 2022

No objection to the changes that add functionality. Probably easiest to discuss the big UI/design changes in Discord.

@sophiajt
Copy link
Contributor

sophiajt commented Jun 23, 2022

Would love to see this broken into parts, with a separate PR for each. Things like the completions dialog are a great improvement even just by themselves.

@fdncred fdncred marked this pull request as draft June 29, 2022 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants