Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add adb&fastboot completions #834

Merged
merged 3 commits into from
May 10, 2024
Merged

feat: add adb&fastboot completions #834

merged 3 commits into from
May 10, 2024

Conversation

undefined-ux
Copy link
Contributor

Although all correct commands have been added where possible, some instructions may be missing

Some instructions may be missing
@fdncred
Copy link
Collaborator

fdncred commented May 10, 2024

I'm not sure that android-platform-tools is a good directory name considering what the other folder names look like. We also usually want to have a readme.md in the folder(s) to describe what this tool is and where to get it.

@undefined-ux
Copy link
Contributor Author

I'm not sure that android-platform-tools is a good directory name considering what the other folder names look like. We also usually want to have a readme.md in the folder(s) to describe what this tool is and where to get it.

I'm sorry about my bad naming, I has break it into two folders to store the completions for adb and fastboot.

@fdncred
Copy link
Collaborator

fdncred commented May 10, 2024

Thanks

@fdncred fdncred merged commit f1b0432 into nushell:main May 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants