Port root before_v0.60/*.nu scripts (issue #221)
#837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`into bits` `into int` already in the core
This script is already ported to `sourced/fehbg.nu`
just `update {|row| ...}`
- `if {} {}` -> `if {} else {}`
- `str find-replace` -> `str replace`
fdncred
reviewed
May 13, 2024
modules/make_readme_table.nu
Outdated
| $cat | ||
| } | ||
| } | where Category !~ ".git" | select Category File | sort-by Category) | ||
|
|
||
| # Let's fix the file now | ||
| let nu_table = ($nu_table | update File { |it| | ||
| let file_path = ($it.File | into string | str find-replace '\\' '/') | ||
| let file_path = ($it.File | into string | str replace '\\' '/') |
There was a problem hiding this comment.
I'm thinking this should probably be str replace '\\' '/' --all, otherwise it just replaces the first one I think.
- add `--all` to replace all occcurencies - `\\` -> '\'. No need to escape backslash in single qoutes
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of porting all old scripts #221 and ports all root
before_v0.60/*.nuscripts tomodules/*.nu