Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add french translation [#1532] #1559

Merged
merged 3 commits into from
Oct 12, 2024
Merged

Conversation

LoicRiegel
Copy link
Contributor

@LoicRiegel LoicRiegel commented Sep 22, 2024

Start a French translation

Linked issue: #1532

I started this translation by translating:

  • the landing page
  • the book's landing page
  • the book's "Getting started" section

How I did it / my approach:

I used ChatGPT to get a first translation draft. Then I carefully proofread everything and rephrased where needed.
My approach was:

  • stay as close as possible as the english version (e.g. how the sentence is built)
  • translate technical terms in french as much as possible, but allow some technical words to remain in English. Examples: "wildcard", "raw" (in "raw strings")
  • when the docs points to another document that is not translated for now, point to the english version
  • I checked especially links
  • All code snippets are strictly the same as the english version

Other thoughts:

Honestly it's sometmes quite hard to find a good translation! Being used to reading and working with code in English every day, this made me realize how much we use English for programming concepts and vocabulary. Sometimes we "englishize" some words, even when a french equivalent might exist...
Anyway, I did my best! But I think another review by a fellow french contributor could still be nice 😄

@LoicRiegel LoicRiegel force-pushed the add-french-translation branch 2 times, most recently from b3b1de4 to b56775f Compare September 24, 2024 19:26
@LoicRiegel LoicRiegel force-pushed the add-french-translation branch 2 times, most recently from 42bbf6c to 1c3ce9c Compare September 24, 2024 19:49
@LoicRiegel
Copy link
Contributor Author

@hustcer the PR is ready: I did the commit cleanup I wanted. Could you approve the workflows to run? Is there something else to do?

@fdncred
Copy link
Collaborator

fdncred commented Sep 24, 2024

lol, looks like spell check doesn't like french. i'm sure there is some way to add that folder to be ignored by spell check but i'm not sure what it is.

@LoicRiegel
Copy link
Contributor Author

lol, looks like spell check doesn't like french. i'm sure there is some way to add that folder to be ignored by spell check but i'm not sure what it is.

Does the spell checker know about the other languages? German, spanish etc? Or are they also excluded from the check already?

@fdncred
Copy link
Collaborator

fdncred commented Sep 24, 2024

Or are they also excluded from the check already?

I'm guessing they're excluded but I'm not sure. You'll have to dig around the repo and look.

@LoicRiegel LoicRiegel force-pushed the add-french-translation branch from 1c3ce9c to 4d58460 Compare September 24, 2024 21:39
@LoicRiegel
Copy link
Contributor Author

LoicRiegel commented Sep 24, 2024

I'm guessing they're excluded but I'm not sure. You'll have to dig around the repo and look.

Okay, wasn't too hard to find actually :) Could you trigger the workflows again please?

@hustcer
Copy link
Collaborator

hustcer commented Sep 24, 2024

@LoicRiegel Great work and a huge thanks, I will review it in a few hours 👍

@hustcer
Copy link
Collaborator

hustcer commented Sep 25, 2024

@LoicRiegel It looks good to me except that the commit SHA is too long for a table cell in i18n-meta.json, it's recommend to use the output of git rev-parse --short HEAD instead.
BTW: I don't know French so I won't read the translation itself.

@fdncred
Copy link
Collaborator

fdncred commented Sep 25, 2024

maybe @amtoine can skim the text?

@LoicRiegel LoicRiegel force-pushed the add-french-translation branch from 4d58460 to 4572429 Compare September 26, 2024 19:53
@LoicRiegel
Copy link
Contributor Author

@LoicRiegel Great work and a huge thanks, I will review it in a few hours 👍

You're welcome! It did take a few hours 😄

I modified the last commit so that i18n meta has the short commit SHA.

@amtoine
Copy link
Member

amtoine commented Oct 5, 2024

grrr NPM does not want to run the website locally... i hate it each time 😭

@hustcer
Copy link
Collaborator

hustcer commented Oct 7, 2024

@LoicRiegel Sorry to keep you waiting, do you want to land this now or do you want to keep on translating more docs on this pr?

@LoicRiegel
Copy link
Contributor Author

@LoicRiegel Sorry to keep you waiting, do you want to land this now or do you want to keep on translating more docs on this pr?

No worries :) No I won't translate more documents in the PR. However I can wait for the review from @amtoine or someone else

@fdncred
Copy link
Collaborator

fdncred commented Oct 10, 2024

antoine mentioned that he doesn't really have time so if @hustcer is good we can land this

@amtoine
Copy link
Member

amtoine commented Oct 12, 2024

yeah there is a lot to read and then, if the English documentation changes, this implies an extra maintenance burden 😕

@LoicRiegel
Copy link
Contributor Author

Okay sure, let's land this then :)
The commits on this branch are good, though behind the main branch now. I can rebase if you want, otherwise I'll let you merge 🚀

@fdncred fdncred merged commit 251f13e into nushell:main Oct 12, 2024
2 checks passed
@fdncred
Copy link
Collaborator

fdncred commented Oct 12, 2024

Thanks

@amtoine
Copy link
Member

amtoine commented Oct 13, 2024

thanks @LoicRiegel 🙏

no need to rebase when there are no conflicts 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants