-
Notifications
You must be signed in to change notification settings - Fork 470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add french translation [#1532] #1559
Conversation
b3b1de4
to
b56775f
Compare
42bbf6c
to
1c3ce9c
Compare
@hustcer the PR is ready: I did the commit cleanup I wanted. Could you approve the workflows to run? Is there something else to do? |
lol, looks like spell check doesn't like french. i'm sure there is some way to add that folder to be ignored by spell check but i'm not sure what it is. |
Does the spell checker know about the other languages? German, spanish etc? Or are they also excluded from the check already? |
I'm guessing they're excluded but I'm not sure. You'll have to dig around the repo and look. |
1c3ce9c
to
4d58460
Compare
Okay, wasn't too hard to find actually :) Could you trigger the workflows again please? |
@LoicRiegel Great work and a huge thanks, I will review it in a few hours 👍 |
@LoicRiegel It looks good to me except that the commit SHA is too long for a table cell in |
maybe @amtoine can skim the text? |
4d58460
to
4572429
Compare
You're welcome! It did take a few hours 😄 I modified the last commit so that i18n meta has the short commit SHA. |
grrr NPM does not want to run the website locally... i hate it each time 😭 |
@LoicRiegel Sorry to keep you waiting, do you want to land this now or do you want to keep on translating more docs on this pr? |
No worries :) No I won't translate more documents in the PR. However I can wait for the review from @amtoine or someone else |
antoine mentioned that he doesn't really have time so if @hustcer is good we can land this |
yeah there is a lot to read and then, if the English documentation changes, this implies an extra maintenance burden 😕 |
Okay sure, let's land this then :) |
Thanks |
thanks @LoicRiegel 🙏 no need to rebase when there are no conflicts 😉 |
Start a French translation
Linked issue: #1532
I started this translation by translating:
How I did it / my approach:
I used ChatGPT to get a first translation draft. Then I carefully proofread everything and rephrased where needed.
My approach was:
Other thoughts:
Honestly it's sometmes quite hard to find a good translation! Being used to reading and working with code in English every day, this made me realize how much we use English for programming concepts and vocabulary. Sometimes we "englishize" some words, even when a french equivalent might exist...
Anyway, I did my best! But I think another review by a fellow french contributor could still be nice 😄