Update python plugin example for compatibility with v0.100.0 #1647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fdncred
reviewed
Nov 23, 2024
| @@ -1081,15 +1081,18 @@ def send_error(id, error_msg, span): | |||
|
|
|||
| def handle_call(id, call_info): | |||
| try: | |||
| input = call_info["input"]["Value"]["String"] | |||
| input = call_info["input"]["Value"][0]["String"] | |||
There was a problem hiding this comment.
This is the only part that gives me pause. Seems odd that we'd have to get the 0th element, but maybe that's right?
|
Yes, the rust and the under-the-hood part need to be updated too. Issues to update them is fine if you don't have that expertise. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the python plugin example code for compatibility with
v0.100.0.NB: the rust example in this document is still at
v0.90.2- I don't have the rust experience to be able to make equivalent updates - it might be best to create an issue for this.