Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionally disable cross-channel history posts #274

Merged
merged 5 commits into from
Feb 7, 2020

Conversation

nuxeh
Copy link
Owner

@nuxeh nuxeh commented Feb 1, 2020

Following discussion in #270

@github-actions
Copy link

github-actions bot commented Feb 1, 2020

Pull Request Test Coverage Report for Build 134cc0c03ed9e20172e0812a426f5662ce9948dd-PR-274

  • 25 of 26 (96.15%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 82.056%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/message.rs 24 25 96.0%
Totals Coverage Status
Change from base Build a729a06577a90e6bf1ec2dc5a400246bc921a559: 0.2%
Covered Lines: 1253
Relevant Lines: 1527

💛 - Coveralls

@codecov
Copy link

codecov bot commented Feb 1, 2020

Codecov Report

Merging #274 into master will increase coverage by 0.89%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #274      +/-   ##
==========================================
+ Coverage   78.36%   79.26%   +0.89%     
==========================================
  Files           8        8              
  Lines        1276     1312      +36     
==========================================
+ Hits         1000     1040      +40     
+ Misses        276      272       -4
Impacted Files Coverage Δ
src/config.rs 94.09% <ø> (ø) ⬆️
src/message.rs 77.53% <100%> (+3.06%) ⬆️
src/http.rs 90.53% <0%> (+0.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 072fdd0...3b21fa9. Read the comment docs.

nuxeh added 4 commits February 5, 2020 02:27
Now, if `cross_channel_history` is not enabled, re-posts are limited to
the same channel they were originally posted into.
@nuxeh nuxeh force-pushed the ed/cross-channel-feature branch from 4b6d861 to 0b8dd16 Compare February 4, 2020 18:28
Even if a pre-post is found, various configurations can cause the result
of this look up to be ignored, meaning another pre-post entry will be
added to the database.

Add a flag to preserve this state, even if the actual result of the
pre-post look up is masked by configuration.

Also fix 0.0.0.0 to 127.0.0.1 after rebase.
@nuxeh nuxeh merged commit a79bf2d into master Feb 7, 2020
@nuxeh nuxeh deleted the ed/cross-channel-feature branch February 7, 2020 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant