Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add ids for injected scripts #333

Merged
merged 4 commits into from
Dec 4, 2023
Merged

feat: add ids for injected scripts #333

merged 4 commits into from
Dec 4, 2023

Conversation

ahmadqwer
Copy link
Contributor

Added IDs to Partytown scripts in nuxt3 as it was added on nuxt2.

@ahmadqwer
Copy link
Contributor Author

I have a case where i need to select Partytown scripts in the html.

@danielroe Volta.net
Copy link
Contributor

What's your use-case?

@ahmadqwer
Copy link
Contributor Author

What's your use-case?

In my project. i remove all scripts from Html using render:response hook, i need an id to partytown scripts (or any attribute) to be able to not removing them from the Html.

@abdaldeen
Copy link

I have the same issue
It would be great to add IDs to the scripts

@danielroe danielroe changed the title Add id to the partytown scripts feat: add ids for injected scripts Dec 4, 2023
@danielroe danielroe merged commit 18addcf into nuxt-modules:main Dec 4, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ahmadqwer @danielroe @abdaldeen @Ahmad-Abdulhafez