fix(module): ensure vi.hoisted is injected after vi import (#1128)

nuxt · Feb 20, 2025 · ef4a74e · ef4a74e
1 parent be7f642
commit ef4a74e
Show file tree

Hide file tree

Showing 4 changed files with 39 additions and 4 deletions.
diff --git a/eslint.config.js b/eslint.config.js
@@ -21,5 +21,6 @@ export default createConfigForNuxt({
 }).append({
   rules: {
     '@typescript-eslint/no-invalid-void-type': 'off',
+    'vue/multi-word-component-names': 'off',
   },
 })
diff --git a/examples/app-vitest-full/components/WrapperTests.vue b/examples/app-vitest-full/components/WrapperTests.vue
@@ -10,7 +10,7 @@ function testExpose() {
 
 const someRef = ref('thing')
 
-const modelValue = defineModel({ default: false })
+const modelValue = defineModel({ type: Boolean, default: false })
 
 defineExpose({
   testExpose,

diff --git a/src/module/plugins/mock.ts b/src/module/plugins/mock.ts
@@ -228,15 +228,15 @@ export const createMockPlugin = (ctx: MockPluginContext) => createUnplugin(() =>
 
     if (!mockLines.length) return
 
-    s.prepend(`vi.hoisted(() => { 
+    s.appendLeft(insertionPoint, `\nvi.hoisted(() => { 
         if(!globalThis.${HELPER_MOCK_HOIST}){
           vi.stubGlobal(${JSON.stringify(HELPER_MOCK_HOIST)}, {})
         }
       });\n`)
 
     if (!hasViImport) s.prepend(`import {vi} from "vitest";\n`)
 
-    s.appendLeft(insertionPoint, mockLines.join('\n') + '\n')
+    s.appendLeft(insertionPoint, '\n' + mockLines.join('\n') + '\n')
 
     // do an import to trick vite to keep it
     // if not, the module won't be mocked

diff --git a/test/unit/mock-transform.spec.ts b/test/unit/mock-transform.spec.ts
@@ -49,11 +49,13 @@ describe('mocking', () => {
         })
       `)).toMatchInlineSnapshot(`
         "import {vi} from "vitest";
+
         vi.hoisted(() => { 
                 if(!globalThis.__NUXT_VITEST_MOCKS){
                   vi.stubGlobal("__NUXT_VITEST_MOCKS", {})
                 }
               });
+
         vi.mock("bob", async (importOriginal) => {
           const mocks = globalThis.__NUXT_VITEST_MOCKS
           if (!mocks["bob"]) {
@@ -77,8 +79,38 @@ describe('mocking', () => {
         from: 'bob',
       }]
       const code = await getResult(`
-        import { expect, vi } from 'vitest'
+        import { expect, vi, it } from 'vitest'
         mockNuxtImport('useSomeExport', () => 'bob')
+        
+        it('test', () => {
+          const a = vi.fn()
+        })
+      `)
+      expect(code).toMatchInlineSnapshot(`
+        "
+                import { expect, vi, it } from 'vitest'
+        vi.hoisted(() => { 
+                if(!globalThis.__NUXT_VITEST_MOCKS){
+                  vi.stubGlobal("__NUXT_VITEST_MOCKS", {})
+                }
+              });
+
+        vi.mock("bob", async (importOriginal) => {
+          const mocks = globalThis.__NUXT_VITEST_MOCKS
+          if (!mocks["bob"]) {
+            mocks["bob"] = { ...await importOriginal("bob") }
+          }
+          mocks["bob"]["useSomeExport"] = await (() => 'bob')();
+          return mocks["bob"] 
+        });
+
+                
+                
+                it('test', () => {
+                  const a = vi.fn()
+                })
+              
+         import "bob";"
       `)
       expect(code).not.toContain('import {vi} from "vitest";')
     })
@@ -101,11 +133,13 @@ describe('mocking', () => {
         mockComponent('MyComponent', () => import('./MockComponent.vue'))
       `)).toMatchInlineSnapshot(`
         "import {vi} from "vitest";
+
         vi.hoisted(() => { 
                 if(!globalThis.__NUXT_VITEST_MOCKS){
                   vi.stubGlobal("__NUXT_VITEST_MOCKS", {})
                 }
               });
+
         vi.mock("MyComponent", async () => {
           const factory = (() => import('./MockComponent.vue'));
           const result = typeof factory === 'function' ? await factory() : await factory