Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ContextMenu/DropdownMenu): handle RTL mode #3744

Merged
merged 4 commits into from
Mar 31, 2025
Merged

fix(ContextMenu/DropdownMenu): handle RTL mode #3744

merged 4 commits into from
Mar 31, 2025

Conversation

malik-jouda
Copy link
Contributor

@malik-jouda malik-jouda commented Mar 30, 2025 •
edited
Loading

🔗 Linked issue

Resolves #3737

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Before:
Screenshot 2025-03-30 at 8 47 08 PM
After:
Screenshot 2025-03-30 at 8 46 48 PM

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Mar 30, 2025 •
edited
Loading 

npm i https://pkg.pr.new/@nuxt/ui@3744

commit: bff3b6e

benjamincanac
benjamincanac reviewed Mar 30, 2025
View reviewed changes
Copy link
Member

@benjamincanac benjamincanac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we just use a flex-row-reverse in rtl? 🤔

@malik-jouda
Copy link
Contributor Author

malik-jouda commented Mar 31, 2025 •
edited
Loading

@benjamincanac
It is better to stay as it is 🙂

@benjamincanac Volta.net
Copy link
Member

I kinda disagree because this behavior needs to be done in most components, it would be way easier to update using a class 😬

@malik-jouda
Copy link
Contributor Author

@benjamincanac
428428225-c8b9c61b-4cae-44ac-9a95-ad698eeae394

You mean in this case?

@benjamincanac Volta.net
Copy link
Member

What? What I mean is this change needs to be applied on ContextMenu, SelectMenu, InputMenu, etc. it would be easier to fix this with something like rtl: flex-row-reverse.

@malik-jouda
Copy link
Contributor Author

@benjamincanac
check the last update 😬

@malik-jouda malik-jouda changed the title fix(DropdownMenu): handle RTL mode fix(ContextMenu/DropdownMenu): handle RTL mode Mar 31, 2025
@benjamincanac benjamincanac merged commit 1ae5cc0 into nuxt:v3 Mar 31, 2025
5 checks passed
@benjamincanac
Copy link
Member

Thanks @malik-jouda! 😊

davestewart added a commit to davestewart/nuxt-ui that referenced this pull request Apr 2, 2025
@davestewart
Merge branch 'docs' of https://github.com/davestewart/nuxt-ui into docs
5dc4d64 
* 'docs' of https://github.com/davestewart/nuxt-ui:
  chore(deps): update nuxt framework to ^3.16.2 (v3) (nuxt#3769)
  feat(Textarea): add `resize-none` class with `autoresize` prop
  feat(Textarea): add `autoresize-delay` prop
  feat(Textarea): add `icon`, `loading`, etc. props to match Input
  chore(Input/InputNumber/PinInput/Textarea): clean functions order
  chore(cli): fix `tv` import
  fix(ContextMenu/DropdownMenu): handle RTL mode (nuxt#3744)
  fix(InputMenu): emit `change` on multiple item removal
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjamincanac benjamincanac benjamincanac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Items in the DropdownMenu have problems in RTL mode
2 participants
@malik-jouda @benjamincanac