Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Integrated babel into build to make bundle compatible with ES5+ #774

Open
wants to merge 1 commit into
base: next
Choose a base branch
from

Conversation

slurmulon
Copy link

Changes

  • Integrated @rollup/plugin-babel into the build so that the bundle contains polyfilled code that is compatible with ES5+.
  • These changes prevent breaking syntax errors on older versions of Chrome, Firefox, Safari, etc.

Gotchas

  • I noticed a small change to dist/vue-meta.d.ts, but I'm not sure why it was introduced. I can dig into this further if needed, it seems like it could impact TypeScript integrations.
    • Interestingly, I ran the build against v3.0.0-alpha.10 and noticed the exact same change, so this does not appear to relate to my change (perhaps it's due to an implicit version bump related to TypeScript).
  • I assumed IE9 as a build target, and this seemed necessary (for some reason) to fully polyfill the code - also happy to experiment with this more if needed/preferred.
  • The size of the bundle naturally increases due to polyfilling (273k -> 357k).

Issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant