Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update packaging scripts to use consolidated platform options #697

Merged
merged 3 commits into from
Feb 21, 2025

Conversation

mocsharp
Copy link
Contributor

@mocsharp mocsharp commented Feb 20, 2025

This PR updates the packaging scripts to use the new consolidated --platform options introduced in CLI 3.0 nvidia-holoscan/holoscan-cli#26

@mocsharp mocsharp requested review from MMelQin and tbirdso February 20, 2025 23:50
@mocsharp mocsharp self-assigned this Feb 20, 2025
@mocsharp mocsharp force-pushed the vchang/consolidate-platform branch 3 times, most recently from 627ea1a to 6cddbb8 Compare February 21, 2025 00:01
@mocsharp mocsharp marked this pull request as ready for review February 21, 2025 00:01
@mocsharp mocsharp force-pushed the vchang/consolidate-platform branch from c9c5d94 to ea7ccc6 Compare February 21, 2025 00:08
Copy link
Contributor

@tbirdso tbirdso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Contributor

@MMelQin MMelQin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@tbirdso tbirdso merged commit 083be3c into nvidia-holoscan:main Feb 21, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants