Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scapy to ANO container #701

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

cliffburdick
Copy link
Contributor

No description provided.

Signed-off-by: Cliff Burdick <[email protected]>
@agirault
Copy link
Contributor

@jjomier @tbirdso what is the guideline when using GPL dependencies in Holohub? This is only for testing, and we're not distributing any containers, so I assume that's ok?

Copy link
Contributor

@agirault agirault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no concern on gpl2 since not distributed. ty

@agirault
Copy link
Contributor

Will wait on #703 first so we can confirm that failures are caught before fixing it. No rush anyway, ty Cliff.

@agirault
Copy link
Contributor

Either way though, this branch doesn't fix it for me:

./dev_container build_and_run adv_networking_bench --no_run --build_args "-D BUILD_TESTING:BOOL=ON"
./dev_container launch --img holohub:adv_networking_bench --docker_opts "-u 0 --privileged" -- bash -c "cd build/adv_networking_bench/ && ctest . --verbose -R adv_networking_bench_dpdk_multi_rx_q_test"
2: 2025-02-25 02:05:48,732 ERROR: Failed to run external script: Command '['/workspace/holohub/applications/adv_networking_bench/cpp/../utils/test_multi_rx_q.py']' returned non-zero exit status 1.
2: Exception in thread Thread-1 (delayed_external_script):
2: Traceback (most recent call last):
2:   File "/usr/lib/python3.10/threading.py", line 1016, in _bootstrap_inner
2:     self.run()
2:   File "/usr/lib/python3.10/threading.py", line 953, in run
2:     self._target(*self._args, **self._kwargs)
2:   File "/workspace/holohub/build/adv_networking_bench/applications/adv_networking_bench/cpp/testing/adv_networking_test_harness.py", line 72, in delayed_external_script
2:     subprocess.run(
2:   File "/usr/lib/python3.10/subprocess.py", line 526, in run
2:     raise CalledProcessError(retcode, process.args,
2: subprocess.CalledProcessError: Command '['/workspace/holohub/applications/adv_networking_bench/cpp/../utils/test_multi_rx_q.py']' returned non-zero exit status 1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants