Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(query): explicitly opt-in to legacy behavior #450

Merged
merged 1 commit into from
Sep 22, 2024

Conversation

dpetka2001
Copy link
Contributor

After neovim/neovim@6913c5e in Neovim nightly, neotest returns No tests found (tested with neotest-python). Since it's mentioned in the PR that the option all = false will be removed in the future, maybe a more robust approach would be preferable, but I don't have the knowledge to implement it. This is just a hotfix until someone else comes with something better.

@GitMurf
Copy link

GitMurf commented Sep 8, 2024

@dpetka2001 does this relate to either of these treesitter commits?

@dpetka2001
Copy link
Contributor Author

No, these are just adjustments in nvim-treesitter plugin as well. The original behavior stems from Neovim builtin treesitter and it's this specific commit.

@GitMurf
Copy link

GitMurf commented Sep 8, 2024

So is this a "breaking change" for potentially many plugins that use treesitter? or is this something that was recently changed with neotest as well that has created a "bug"? I am just trying to figure out what the intended impact is overall and if I need to watch out for issues like this with other plugins that utilize treesitter in particular ways? Thanks!

@dpetka2001
Copy link
Contributor Author

Yes, it's a breaking change. It's also mentioned in the PR itself

BREAKING CHANGE: Any plugin which uses Query:iter_matches() must update their call sites to expect an array of nodes in the match table, rather than a single node.

And you can also see it from the title of the convetional commit feat(treesitter)!, where the exclamation mark is used to identify breaking changes. Another plugin that I noticed had problems with this breaking change from the ones that I use was vim-matchup. I'm sure there might be other as well, but don't use them so don't really know.

@rcarriga rcarriga merged commit 5be28ff into nvim-neotest:master Sep 22, 2024
4 checks passed
@rcarriga
Copy link
Collaborator

Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants