feat: Add README icons #381
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Holding off pending #376 |
Ok. |
|
@DreepyYunky i think you should also add for |
I even might add for files just named |
|
@pauchiner Added |
|
Sorry, I don't think we should do this: markdown and text are file types, readme is not. web-devicons only handles types, particularly those specified by languages. That's kind of confirmed by the lack of readme icon in nerd fonts ;) If you desire special file name handling you can use API |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
READMEs (eg
README.md) are special files, so giving them special icon can help distinct them from, for example, an average markdown file.The icon is
nf-md-informationwhich I think fits since READMEs give information about the thing it's on.