feat: add http #497
Merged
feat: add http #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Colours look good dark: and light (I generated this one from dark): |
alex-courtis
requested changes
Sep 20, 2024
There was a problem hiding this comment.
I'm not quite sure of the use case, but this looks good.
Build https://github.com/nvim-tree/nvim-web-devicons/actions/runs/10942703932/job/30409605842?pr=497 is failing due to a light colour mismatch.
The light versions are all generated, please use the tool https://github.com/nvim-tree/nvim-web-devicons/blob/master/CONTRIBUTING.md#generate-colors
It is for files containing HTTP requests. They can be used with HTTP clients like rest.nvim or kulala.nvim. I have now auto generated the light colors 🙂 |
alex-courtis
approved these changes
Sep 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feel free to change the icon and/or colors. I picked the colors from this logo on wikipedia. I'm not sure how established it is though.