Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add adb ads gpr #514

Merged
merged 2 commits into from
Nov 25, 2024
Merged

Conversation

nerdtype
Copy link
Contributor

Add icon for '.adb', '.ads', and '.gpr' file types.

Copy link
Member

@alex-courtis alex-courtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we please use the ada icon?

nf-custom-ada

https://www.nerdfonts.com/cheat-sheet

@nerdtype
Copy link
Contributor Author

From an end-user perspective- as an Ada software developer using nvim (with nvim-tree), what would add value to me is being able to differentiate between the primary Ada source files and indicate the particular function of the files.

In Ada, this can be summarized to the following files:

.adb - Body
.ads - Specification
.gpr - GNAT GPRBuild project

To this end, I have selected icons which visually align with the function of the file being represented and would prefer to keep those selected.

@nerdtype nerdtype closed this Nov 24, 2024
@nerdtype nerdtype reopened this Nov 24, 2024
@alex-courtis
Copy link
Member

From an end-user perspective- as an Ada software developer using nvim (with nvim-tree), what would add value to me is being able to differentiate between the primary Ada source files and indicate the particular function of the files.

web-devicons provides the actual icons for file types, rather than abstract arbitrary icons.

Suggestions:

  1. Use colours to differentiate the icons for adb, ads...
  2. Provide your custom icons via setup/api https://github.com/nvim-tree/nvim-web-devicons?tab=readme-ov-file#setup

@nerdtype
Copy link
Contributor Author

If you we going to use a font glyph to represent Ada file types, we should at least use the latest and (most popular) Ada logo:

https://blog.adacore.com/our-contribution-to-the-ada-logo-discussion

image

@nerdtype
Copy link
Contributor Author

Switch to using 'nf-custom-ada' glpyh for Ada file types.

Copy link
Member

@alex-courtis alex-courtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for your contribution!

@alex-courtis alex-courtis changed the title feat: add Ada icons feat: add adb ads gpr Nov 25, 2024
@alex-courtis alex-courtis merged commit edbe0a6 into nvim-tree:master Nov 25, 2024
4 checks passed
@nerdtype
Copy link
Contributor Author

Thanks Alex!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants