feat: add ada icon, use c colours for ada icons #577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsaenztagarro
force-pushed
the
sensible-ada-icons
branch
from
a40f5c5 to
3d538f7
Compare
dsaenztagarro
changed the title
gegoune
approved these changes
Apr 8, 2025
|
@gegoune following the issue thread see my lastest comment. Summarizing:
That's all. Don't hesitate to comment any concern before approval if you think is needed. |
|
Doesn't look like there are any official recommendations around ada logo colours so c-like makes sense. Many thanks for your contribution! |
alex-courtis
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #578
I have set the icons colors so they are consistent with their counterpart on C development (i.e. keep colors similar to
.hand.cextensions, andMakefile).Here the results: