Skip to content

feat: add svgz and tmpl icons #587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

hankertrix
Copy link
Contributor

Svgz files are Gzipped compressed SVG files. Template files ending in tmpl are Chezmoi templates. Let me know if I should use different icons for these.

hankertrix added 4 commits May 8, 2025 17:46
Svgz files are Gzipped compressed SVG files. Template files ending in
tmpl are Chezmoi templates. Let me know if I should use different icons
for these.
@gegoune
Copy link
Collaborator

gegoune commented May 8, 2025

Not sure if tmpl is exclusive to Chezmoi, doubt it is.

@hankertrix
Copy link
Contributor Author

hankertrix commented May 8, 2025

Should I make it generic for template files? I think the icon is sufficiently generic, as there’s no icon for chezmoi. The colour could be changed to the colour for regular text files.

Another icon could be this: 󰘓

@alex-courtis
Copy link
Member

For svgz, could we just use the svg icon?
nf-md-svg see https://www.nerdfonts.com/cheat-sheet

Should I make it generic for template files? I think the icon is sufficiently generic, as there’s no icon for chezmoi. The colour could be changed to the colour for regular text files.

Another icon could be this: 󰘓

That icon nf-md-file_hidden is not used, however it may be more suited to a hidden file than a template.

@alex-courtis
Copy link
Member

Not sure if tmpl is exclusive to Chezmoi, doubt it is.

Should I make it generic for template files? I think the icon is sufficiently generic, as there’s no icon for chezmoi. The colour could be changed to the colour for regular text files.

Another icon could be this: 󰘓

We have a generic templ icon nf-cod-code which could be a kind of js/velocity/php template.

@gegoune could we just re-use that one?

@hankertrix
Copy link
Contributor Author

For svgz, could we just use the svg icon?

Yeap we definitely could, though not a lot of applications can open svgz directly, especially browsers. Notably, Google Chrome dropped support for it around version 72 and there’s a 25 year old bug in Firefox regarding svgz support.

We have a generic templ icon nf-cod-code which could be a kind of js/velocity/php template.

Ah I see, I can change the icon to that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants