fix: js inner without curly braces #511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ValJed
changed the title
ValJed
changed the title
ValJed
commented
Oct 25, 2023
|
It looks very good! By the way, did the behaviour in Python change? Maybe the python parser has some updates? The python test is failing maybe because of that |
|
The Python tests are failing already since a long time. I did not investigate the reasons for that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following some posts I found about removing the curly braces of inner selections.
Like for functions and methods it feels logical to me that it would behave the same for other blocks.
I updated the ecma text objects to select only the inner part for loops and if statements.
I tested locally it seems working nicely, let me know if I made some mistakes, I basically reused code I found. (not familiar with the syntax).