Fix unsafe vector data pointer access

nx10 · Apr 7, 2024 · dc46f97 · dc46f97
1 parent b25ab9d
commit dc46f97
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/base_64.cpp b/src/base_64.cpp
@@ -126,7 +126,7 @@ inline std::string raster_to_string(std::vector<unsigned int> raster_, int w, in
   }
 
   std::vector<std::uint8_t> buffer;
-  png_set_rows(png, info, &rows[0]);
+  png_set_rows(png, info, rows.data());
   png_set_write_fn(png, &buffer, png_memory_write, NULL);
   png_write_png(png, info, PNG_TRANSFORM_IDENTITY, NULL);
   png_destroy_write_struct(&png, &info);

diff --git a/src/unigd_external.cpp b/src/unigd_external.cpp
@@ -13,7 +13,7 @@ using unigd_handle_t = unigd_handle<unigd::unigd_device>;
 
 unigd_find_results find_results::c_repr()
 {
-  return {state, static_cast<plot_index_t>(ids.size()), &ids[0]};
+  return {state, static_cast<plot_index_t>(ids.size()), ids.data()};
 }
 
 int api_test_fun() { return 7; }
@@ -163,7 +163,7 @@ UNIGD_RENDERERS_HANDLE api_renderers(unigd_renderers_list *renderer)
     re->emplace_back(it.second.info);
   }
 
-  *renderer = {&((*re)[0]), re->size()};
+  *renderer = {(*re).data(), re->size()};
 
   return re;
 }