-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT] 인터뷰 룸 관련 페이지 반응형 디자인 적용 및 토큰 에러 인터셉터 작성 #58
Open
moondrop0816
wants to merge
6
commits into
dev
Choose a base branch
from
style/responsive-design-#30
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
53d3d4c
[FIX] 요청시 토큰 에러 발생할 경우 인터셉트 작성 #30
moondrop0816 0cda2b5
[CHORE] 반응형 코드 작성중 #30
moondrop0816 e6567a3
[MERGE] merge dev #30
moondrop0816 4d268c6
[DESIGN] 인터뷰 룸 리스트 반응형 적용 #30
moondrop0816 e3a6245
[DESIGN] 인터뷰 상세페이지 반응형 적용 #30
moondrop0816 8df0931
[DESIGN] 인터뷰 검색 반응형 적용 #30
moondrop0816 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
혹시 이부분 테스트 해보셨나요?? 로그인되지 않은 상태에서 로그인이 필요한 페이지로 접근했을 때 auth와 refresh를 무한 재요청하고 있습니다........ㅜㅜ
아마 인터셉터가 전역으로 설정되어 있어서가 아닐까 싶은데 (auth에서 intercept, refresh에서 intercept.... 반복? 그냥 제 예상입니다)
이 문제가 아니더라도 axios 설정 로직이 길어지니까 App.tsx에서 분리하는게 좋을 것 같아서 intercept가 필요한 요청은 따로 axios instance를 만들어서 쓰는게 좀 더 깔끔할 것 같다는 생각이 듭니다...ㅎㅎ
auth, refresh 재요청 하는 부분은 다시 확인해보셔야 할 것 같습니다!!!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
으아아 죄송합니다 제가 테스트가 부족했어요..ㅠㅠㅠㅠ 다른 요청시 토큰 만료 에러가 잘 동작하는지만 확인하고 로그인 하지 않았을때를 제대로 확인해보지 않은거같아요ㅠ 이부분은 auth, refresh 등 로그인 부분만 별도의 axios 인스턴스를 작성해서 해결해보겠습니다...!!