Fixed optional field for GetAvailabilityResponse
#169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atejada
suggested changes
Nov 14, 2023
There was a problem hiding this comment.
Sorry @mrashed-dev but this fix gets me this error
Required value 'timeSlots' (JSON name 'time_slots') missing at $
I'm trying to find the root cause but I can't
|
@atejada fixed! |
atejada
suggested changes
Nov 14, 2023
There was a problem hiding this comment.
@mrashed-dev Hate to be this kind of guy, but...
class com.nylas.models.GetAvailabilityResponse cannot be cast to class com.nylas.models.Response (com.nylas.models.GetAvailabilityResponse and com.nylas.models.Response are in unnamed module of loader 'app')
😭
|
@atejada not at all, sorry for the bugs. Thanks for testing, I think we should be good now but please test and let me know! |
atejada
approved these changes
Nov 15, 2023
mrashed-dev
deleted the
TW-2425-get-availability-error-in-kotlin-java
branch
Merged
mrashed-dev
added a commit
that referenced
this pull request
Nov 21, 2023
# Changelog ### Added * Added support for the free-busy endpoint (#163) * Added support for Messages, Drafts, and Smart Compose APIs (#166) * Added support for custom authentication, connectors, and credentials APIs (#165) * Added support for folders API (#168) * Added support for attachments API (#171) * Added getter for `GetFreeBusyResponse` `object` field (#172) ### Changed * Return webhook object with secret when creating a webhook (#162) * Fixed HTTP method for rotating webhook secret (#164) * Fixed Redirect URI endpoint path (#167) * Fixed query parameter serialization (#167) * Fixed optional field for `GetAvailabilityResponse` (#169) * Fixed optional field for `Conferencing` (#170) # License <!-- Your PR comment must contain the following line for us to merge the PR. --> I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the response object for getting availability,
orderis only populated for round-robin events.License
I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.