Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add getter for GetFreeBusyResponse object type #172

Merged

Conversation

mrashed-dev
Copy link
Contributor

Description

Adds a getter for getting the object type of a free busy response (free busy vs. error).

License

I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.

Copy link
Contributor

@atejada atejada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm getting this error

Exception in thread "main" java.lang.ClassCastException: class java.util.ArrayList cannot be cast to class com.nylas.models.GetFreeBusyResponse (java.util.ArrayList is in module java.base of loader 'bootstrap'; com.nylas.models.GetFreeBusyResponse is in unnamed module of loader 'app')

@mrashed-dev
Copy link
Contributor Author

@atejada Good catch, I was not returning the correct type

Copy link
Contributor

@atejada atejada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just test it! Let's 🚀

@mrashed-dev mrashed-dev merged commit 97254ff into v2.0.0-beta Nov 17, 2023
1 check passed
@mrashed-dev mrashed-dev deleted the TW-2436-get-free-busy-response-missing-get-object branch November 17, 2023 22:42
mrashed-dev added a commit that referenced this pull request Nov 21, 2023
# Changelog

### Added
* Added support for the free-busy endpoint (#163)
* Added support for Messages, Drafts, and Smart Compose APIs (#166)
* Added support for custom authentication, connectors, and credentials
APIs (#165)
* Added support for folders API (#168)
* Added support for attachments API (#171)
* Added getter for `GetFreeBusyResponse` `object` field (#172)

### Changed
* Return webhook object with secret when creating a webhook (#162)
* Fixed HTTP method for rotating webhook secret (#164)
* Fixed Redirect URI endpoint path (#167)
* Fixed query parameter serialization (#167)
* Fixed optional field for `GetAvailabilityResponse` (#169)
* Fixed optional field for `Conferencing` (#170)

# License
<!-- Your PR comment must contain the following line for us to merge the
PR. -->
I confirm that this contribution is made under the terms of the MIT
license and that I have the authority necessary to make this
contribution on behalf of its copyright owner.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants