Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor model fixes for v2 beta 4 #190

Closed
wants to merge 4 commits into from
Closed

Conversation

mrashed-dev
Copy link
Contributor

Description

The following fixes were done:

  • Fix fromJson error when using CreateConnectorAdapter
  • Annotate WebhookDeleteResponse

License

I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.

Add extra space to be compliant with the Linter
Copy link
Contributor

@atejada atejada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a command on Slack. The provider is not being send to the create method, even though is there.

AaronDDM
AaronDDM previously approved these changes Jan 11, 2024
@mrashed-dev
Copy link
Contributor Author

Closing in favour of #192

@mrashed-dev mrashed-dev deleted the v2-b4-minor-fixes branch January 16, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants