Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FindAttachmentQueryParams to return FindAttachmentQueryParams #208

Conversation

atejada
Copy link
Contributor

@atejada atejada commented Feb 13, 2024

Make FindAttachmentQueryParams return FindAttachmentQueryParams

https://nylas.atlassian.net/browse/TW-2559

License

I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.

Make FindAttachmentQueryParams return FindAttachmentQueryParams
@mrashed-dev mrashed-dev merged commit 91f7ee7 into main Feb 13, 2024
2 checks passed
@mrashed-dev mrashed-dev deleted the TW-2559---FindAttachmentQueryParams-builder-returns-FindEventQueryParams branch February 13, 2024 16:01
@mrashed-dev mrashed-dev linked an issue Feb 13, 2024 that may be closed by this pull request
@mrashed-dev mrashed-dev mentioned this pull request Feb 27, 2024
mrashed-dev added a commit that referenced this pull request Feb 27, 2024
# Changelog
### Added
* Added support for `roundTo` field in availability response (#215)
* Added support for `attributes` field in folder model (#215)
* Added support for icloud as an auth provider (#215)

### Changed
* Fixed builder for FindAttachmentQueryParams (#208)
* Fixed scopes to be optional for IMAP grants (#210)
* Fixed typo in updating grant schema (#211)
* Fixed endpoint for rotating webhook secrets (#212)
* Fixed response type for returning webhook IP addresses (#213)

### Removed
* Removed unnecessary `clientId` from detectProvider params (#215)

# License
<!-- Your PR comment must contain the following line for us to merge the
PR. -->
I confirm that this contribution is made under the terms of the MIT
license and that I have the authority necessary to make this
contribution on behalf of its copyright owner.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FindAttachmentQueryParams builder returns FindEventQueryParams
2 participants