Update Webhooks Ip Addresses #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An Array is expected, not an object. ListResponse was generating the wrong result.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #213 +/- ##
=========================================
Coverage 78.53% 78.53%
Complexity 199 199
=========================================
Files 29 29
Lines 722 722
Branches 69 69
=========================================
Hits 567 567
Misses 117 117
Partials 38 38 ☔ View full report in Codecov by Sentry. |
mrashed-dev
approved these changes
Feb 21, 2024
…turn-a-response-not-a-ListResponse
mrashed-dev
deleted the
TW-2596-Java/Kotlin---Ip-Addresses-should-return-a-response-not-a-ListResponse
branch
Merged
mrashed-dev
added a commit
that referenced
this pull request
Feb 27, 2024
# Changelog ### Added * Added support for `roundTo` field in availability response (#215) * Added support for `attributes` field in folder model (#215) * Added support for icloud as an auth provider (#215) ### Changed * Fixed builder for FindAttachmentQueryParams (#208) * Fixed scopes to be optional for IMAP grants (#210) * Fixed typo in updating grant schema (#211) * Fixed endpoint for rotating webhook secrets (#212) * Fixed response type for returning webhook IP addresses (#213) ### Removed * Removed unnecessary `clientId` from detectProvider params (#215) # License <!-- Your PR comment must contain the following line for us to merge the PR. --> I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An Array is expected, not an object. ListResponse was generating the wrong result.
https://nylas.atlassian.net/browse/TW-2596
License
I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.