Add DetectProvider to Connectors #214
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DetectProvider is on Auth but should be on Connectors too and Client shouldn’t be a parameter. This add consistency with the Ruby SDK
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #214 +/- ##
============================================
- Coverage 78.53% 78.20% -0.33%
Complexity 199 199
============================================
Files 29 29
Lines 722 725 +3
Branches 69 69
============================================
Hits 567 567
- Misses 117 120 +3
Partials 38 38 ☔ View full report in Codecov by Sentry. |
|
Closed in favour of #215. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DetectProvider is on Auth but should be on Connectors too and Client shouldn’t be a parameter. This add consistency with the Ruby SDK
https://nylas.atlassian.net/browse/TW-2600
License
I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.